Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Side Nav Improvements #133

Merged
merged 11 commits into from
May 16, 2024
Merged

Side Nav Improvements #133

merged 11 commits into from
May 16, 2024

Conversation

colegoldsmith
Copy link
Collaborator

@colegoldsmith colegoldsmith commented May 10, 2024 •
edited
Loading

Completes #123

Initial Ideas:
Screenshot 2024-05-09 at 2 08 57 PM

I have added these improvements

  • Nav item titles can now optionally include a link, making the expand/contract chevron a separate smaller button
  • Open in new icon for external links in the side nav and global nav dropdown items
  • Improved accessibility for the side nav, mainly hiding the collapsed content from screen readers until the collapse is opened

Update

I have backed out the ability for a nav item to be a link if it is a list title. The other improvements still apply

@mlr
Copy link
Contributor

mlr commented May 10, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 10, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

eric-schneider
eric-schneider reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@eric-schneider eric-schneider left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I clicked on a parent nav item, it loaded the page as expected, but the nav didn't expand to reveal the items underneath the parent. My expectation was that clicking anywhere on a parent nav item (either the link or the caret button) would reveal the next level underneath the parent.

@kurtenj what do you think?

2024-05-13_19-56-07.mp4

@aimurphy
Copy link

My expectation was that clicking anywhere on a parent nav item (either the link or the caret button) would reveal the next level underneath the parent.

I agree. Clicking either the caret or the parent itself should expand its children. This should also happen if you arrive directly on the parent page (like from Google or a direct link).

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 15, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 16, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 16, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@mlr
Copy link
Contributor

mlr commented May 16, 2024 •
edited
Loading

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@mlr
Copy link
Contributor

mlr commented May 16, 2024 •
edited
Loading

Antora site build successful! ✅
Deploying draft.
Deployment successful! View draft

@colegoldsmith colegoldsmith merged commit 1c82089 into main May 16, 2024
2 checks passed
@colegoldsmith colegoldsmith deleted the nav-list-updates branch May 16, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-schneider eric-schneider eric-schneider left review comments

@mlr mlr mlr approved these changes

Assignees

@colegoldsmith colegoldsmith

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@colegoldsmith @mlr @aimurphy @eric-schneider