-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use node global context to get assetManifest #139
base: main
Are you sure you want to change the base?
Conversation
UI bundle preview build successful! ✅ |
let manifestPath | ||
let manifest | ||
try { | ||
manifestPath = execSync('find ./build/site -name assets-manifest.json').toString().trim() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realized we can't read the UI bundle files at this point in the Antora build because the 'build' folder isn't created until after the page composer step (where these handlebars helpers are used). The only way I see to access this assets-manifest file is using the uiCatalog in an Antora extension and somehow make that object available to this helper, thus the global context
@colegoldsmith looks like the Antora build was unsuccessful. It didn't post a comment back here due to the error being too long https://github.com/riptano/datastax-docs-site/actions/runs/9389755534/job/25857983644#step:11:51 oh – maybe because it needs the asset manifest extension in your other PR |
Yeah, the codependency between the UI and the extension creates a bit of a split-brain scenario between this PR and the one in datastax-docs-site. |
The preview build for this pull request has been cleaned up due to being stale. Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site. You can rebuild the preview at any time by pushing a new commit to this pull request:
|
Relies on an Antora extension to set the assets-manifest object on the node global context