Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node global context to get assetManifest #139

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colegoldsmith
Copy link
Collaborator

Relies on an Antora extension to set the assets-manifest object on the node global context

@mlr
Copy link
Contributor

mlr commented Jun 5, 2024

UI bundle preview build successful! ✅
Deploying preview to GitHub Pages.
Deployment successful! View preview

@colegoldsmith colegoldsmith requested a review from mlr June 5, 2024 20:24
let manifestPath
let manifest
try {
manifestPath = execSync('find ./build/site -name assets-manifest.json').toString().trim()
Copy link
Collaborator Author

@colegoldsmith colegoldsmith Jun 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized we can't read the UI bundle files at this point in the Antora build because the 'build' folder isn't created until after the page composer step (where these handlebars helpers are used). The only way I see to access this assets-manifest file is using the uiCatalog in an Antora extension and somehow make that object available to this helper, thus the global context

@mlr
Copy link
Contributor

mlr commented Jun 5, 2024

@colegoldsmith looks like the Antora build was unsuccessful. It didn't post a comment back here due to the error being too long https://github.com/riptano/datastax-docs-site/actions/runs/9389755534/job/25857983644#step:11:51

oh – maybe because it needs the asset manifest extension in your other PR

@eric-schneider
Copy link
Contributor

maybe because it needs the asset manifest extension

Yeah, the codependency between the UI and the extension creates a bit of a split-brain scenario between this PR and the one in datastax-docs-site.

Copy link
Contributor

The preview build for this pull request has been cleaned up due to being stale.

Preview builds that were 2 weeks old or older were automatically removed to maintain a tidy GitHub Pages site.

You can rebuild the preview at any time by pushing a new commit to this pull request:

git checkout cache-busting-v2
git commit --allow-empty -m 'rebuild preview'
git push origin cache-busting-v2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants