Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-std: Add support for thread_local_key #207

Closed
flaub opened this issue Jul 16, 2022 · 1 comment
Closed

rust-std: Add support for thread_local_key #207

flaub opened this issue Jul 16, 2022 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@flaub
Copy link
Member

flaub commented Jul 16, 2022

From discord:

Currently, any crate which depends on once_cell (including std::collections::HashMap) will compile but experience a runtime panic because the method thread_local_key is unimplemented.

Exception { what: "panicked at 'should not be used on this target', /risc0-rust-starter/target/debug/build/methods-e1d0c7ab6d906214/out/rust-std_5394976e3be5c2fbe950f41f75eb392cd888657933629544e0a55a75bb0e59d9/library/std/src/sys/unsupported/thread_local_key.rs:25:5" }'

Since the zkvm is single-threaded, it seems like this should be relatively straightforward.

@flaub flaub added the enhancement New feature or request label Jul 16, 2022
@shkoo
Copy link
Contributor

shkoo commented Jul 27, 2022

Should be fixed by #216

@shkoo shkoo closed this as completed Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants