Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate metal due to recent MTLCompilerService limitations #999

Closed
flaub opened this issue Oct 17, 2023 · 5 comments
Closed

Deprecate metal due to recent MTLCompilerService limitations #999

flaub opened this issue Oct 17, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@flaub
Copy link
Member

flaub commented Oct 17, 2023

See: #937

The metal HAL on recent versions of macOS fail to compile due to new limitations on the number of temporary registers allowed in a given function. There doesn't seem to be any easy/low cost way to fix the code generator for eval_check, so our best option at this time is to deprecate Metal support and hope that:

  1. Apple raises the limitation in a future macOS release
  2. New zirgen compiler will be able to produce a more structured function that doesn't require so many outstanding registers at any given time.
@flaub flaub added the documentation Improvements or additions to documentation label Oct 17, 2023
@flaub flaub added this to the 0.19 milestone Oct 17, 2023
@flaub
Copy link
Member Author

flaub commented Nov 2, 2023

@flaub flaub modified the milestones: 0.19.0, 0.19.1, 0.20.0 Nov 3, 2023
@weikengchen
Copy link
Contributor

Since M2 seems to be fine, maybe it is okay not to deprecate metal?

@flaub
Copy link
Member Author

flaub commented Nov 8, 2023

AFAIK, this failure occurs on M1 and M2. It seems to work if you happen to have an older version of the Metal compiler. We have a caching system that attempts to avoid long compile times, but this cache might make it seem that things are working even on newer versions.

@flaub
Copy link
Member Author

flaub commented Dec 9, 2023

Metal seems to be working in latest macOS again.

@flaub flaub closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2023
@weikengchen
Copy link
Contributor

That is good news!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants