Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit ffb2f6d:
commit c261119
due to 5.12 riscv header file doesn't define
__ARCH_WANT_RENAMEAT
, which means for riscv64, kernel doesn't support syscall forrenameat
, my solution is define a bionic api by myself and encapsulate calling ofrenameat2
instead.I have tested it and build sdk_phone64_riscv64 and run successfully.
I also used the 5.12 header files before and run bionic unit test on 5.10 kenrel before and syscall related cases are passed. Details please refer to https://github.com/aosp-riscv/test-riscv/tree/riscv64-android-12.0.0_dev/bionic/reports.
Note: keep two commits just for better code review experience. Please rebase and squash them before merge.