implement generate cmake-main.xxx.inc by scripts #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cmake-main.xxx.inc files should be generated by scripts, not by manual. Following changes to support adding riscv64 part. - added "qemu-system-riscv64" targets in android-qemu2-glue/scripts/gen-cmake.py - added configs in default-configs/riscv64-softmmu.mak so the generated cmake-main.xxx.inc share the same qemu2-shared for arm/x86/riscv. Double-checked and found the new configs all exists both for other ARCH such as ARM/X86. - updated CMakeLists.txt, optimized the code due to we should use ./accel/stubs/hvf-stub.c not ./hvf-stub.c, these two files are same. And now ./accel/stubs/hvf-stub.c is included in generated .inc files. With upon changes, we can generated the cmake-main.xxx.inc files as below: ``` ./android/scripts/unix/build-qemu-android.sh --verbose --host=linux-x86_64 ./android-qemu2-glue/scripts/gen-cmake.py -i \ ../../prebuilts/android-emulator-build/qemu-upstream/ -r . \ -o <path_to_generated_files> ``` Noted: due to I only tested linux-x86_64, so in this commit, I only updated cmake-main.linux-x86_64.inc. Signed-off-by: Chen Wang <wangchen20@iscas.ac.cn>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cmake-main.xxx.inc files should be generated by scripts, not
by manual.
Following changes to support adding riscv64 part.
cmake-main.xxx.inc share the same qemu2-shared for arm/x86/riscv.
Double-checked and found the new configs all exists both for other
ARCH such as ARM/X86.
./accel/stubs/hvf-stub.c not ./hvf-stub.c, these two files are same.
And now ./accel/stubs/hvf-stub.c is included in generated .inc files.
With upon changes, we can generated the cmake-main.xxx.inc files as
below:
Noted: due to I only tested linux-x86_64, so in this commit, I only
updated cmake-main.linux-x86_64.inc.
Signed-off-by: Chen Wang wangchen20@iscas.ac.cn