Add k-ext support with v1.0.0-rc #254

pz9115 · 2021-03-30T06:48:42Z

PLCT had add k-ext support with crypto spec v0.90 with finish all regress testing in binutils part, please check it.

Nelson1225 · 2021-03-30T07:20:32Z

Shouldn't these be sent to riscv-binutils-experiment branch?

jim-wilson

Overall it looks OK. There are a just a few minor questions I have, and some apparent issues with changing the patch base which confused the patch a little.

bfd/elfxx-riscv.c

gas/config/tc-riscv.c

include/opcode/riscv.h

opcodes/riscv-dis.c

opcodes/riscv-opc.c

jim-wilson · 2021-03-30T20:04:32Z

In general, I would prefer that patches go upstream. Branches here in github.com/riscv/riscv-binutils-gdb are becoming a serious liability. But we are still in the process of moving stuff upstream (waiting for gcc-11 branch), and using github for patch reviews is probably more convenient than email for many people.
]

jim-wilson · 2021-03-30T20:10:00Z

Kito's review of the K gcc patch reminds me, I didn't see testcases. It is generally a good idea to add a gas testcase for new extensions, to verify that we can assemble all of the instructions, and then disassemble them correctly.

We will also need to make sure we didn't accidentally break gdb. We can't do that in riscv-gnu-toolchain because we use different release branches for binutils and gdb. But in the FSF development tree, binutils and gdb development sources are on the same master branch.

bfd/elfxx-riscv.c

Nelson1225

Generally looks good, except the k expansions, GNU coding standards and CSR issue. We don't need to care the k expansions here, we can fix them when sending the draft k stuff to the FSF users/riscv/binutils-integration-branch.

However, we should all pay attention to the GNU coding standards. You can refer to my previous three patches as follows,

RISC-V: Comments tidy and improvement.
RISC-V: Error and warning messages tidy.
RISC-V: Indent and GNU coding standards tidy, also aligned the code.

After fixing the GNU comments and indents, and the CSR problem, the patch looks good to me.

Nelson1225 · 2021-06-09T04:01:23Z

bfd/elfxx-riscv.c

@@ -1760,6 +1761,66 @@ riscv_parse_add_implicit_subsets (riscv_parse_subset_t *rps)
    riscv_parse_add_subset (rps, "zicsr",
 			    RISCV_UNKNOWN_VERSION,
 			    RISCV_UNKNOWN_VERSION, TRUE);
+  else if ((riscv_lookup_subset (rps->subset_list, "k", &subset)))


I suppose k, zkn and zks are similar to g, they used to expand into others. We won't output g to the final architecture string, so k, zkn and zks should be the same. I had done some improvement on FSF binutils about this, so it might be easier to complete over there.

However,my old implementation here did not consider so much, so it looks OK.

Okay, if it need change, I will update it.

Nelson1225 · 2021-06-09T04:03:55Z

gas/config/tc-riscv.c

@@ -143,6 +143,18 @@ static const struct riscv_ext_version ext_version_table[] =
  {"zba",   ISA_SPEC_CLASS_DRAFT, 0, 93},
  {"zbc",   ISA_SPEC_CLASS_DRAFT, 0, 93},

+  {"k",   ISA_SPEC_CLASS_DRAFT, 0, 90},


Same as above, if k, zkn and zks are expansions, then we don't need to add the default versions for them.

Okay, I deleted the version for k,zkn,zks.

Sorry that may have misunderstood you. I meant this is OK for riscv-binutils-experiment, but could be improved in the FSF binutils. Therefore, we don't need to care about the k and p's expansions in the riscv-binutils-experiment.

Ok, let me delete the expansions with k,zkn,zks in the riscv-binutils-experiment..

gas/config/tc-riscv.c

bfd/elfxx-riscv.c

include/opcode/riscv-opc.h

Nelson1225 · 2021-06-09T04:23:07Z

FYI, you can press the "Resolve conversation" if you have fixed them. So that the PR will look a little cleaner, thanks.

Fix intend problems and update CSR testcases, delete the version for k, zkn, zks.

Nelson1225

LGTM, thanks.

Nelson1225 · 2021-06-09T08:21:03Z

include/opcode/riscv-opc.h

@@ -710,6 +776,7 @@
 #define CSR_MARCHID 0xf12
 #define CSR_MIMPID 0xf13
 #define CSR_MHARTID 0xf14
+#define CSR_MENTROPY 0xf15


Maybe you forgot this one :)

Thank you for your metion, I had update the 'mentorpy' case.

Update the CRS testcases and remove the expand for 'k',‘zkn’,'zks'.

Update the testcases with csr define.

Update to spec v0.93, change mentropy into sentropy, update some aes encoding with 'bs', change 'rcon' into 'rnum'.

Update the aes32* opcode and csr with spec v0.94.

pz9115 · 2021-08-23T09:46:35Z

We had updated with the scalar crypto spec 1.0.0-rc, and merge it with the b-ext spec 1.0.0-rc contants zba_zbb_zbc_zbs for reusing of zbk[bcx]. Sorry for the miss closing of this PR due to branch rename.

Update with spec 1.0.0-rc4

pz9115 · 2022-06-14T07:35:21Z

This work had been merged into the binutils upstream branch

https://sourceware.org/git/?p=binutils-gdb.git

close the PR.

kito-cheng requested a review from Nelson1225 March 30, 2021 06:54

pz9115 changed the base branch from riscv-binutils-2.36 to riscv-binutils-experiment March 30, 2021 07:44

pz9115 changed the title ~~Add k-ext support with v0.93~~ Add k-ext support with v0.90 Mar 30, 2021

jim-wilson reviewed Mar 30, 2021

View reviewed changes

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch from 92ff7c9 to b426ce6 Compare March 31, 2021 08:53

Nelson1225 reviewed Apr 1, 2021

View reviewed changes

bfd/elfxx-riscv.c Outdated Show resolved Hide resolved

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch 5 times, most recently from a69bb36 to 72ef429 Compare April 14, 2021 06:42

Support Krypoto Scalar Extension with spec V0.90

1a01c9a

pz9115 closed this Apr 28, 2021

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch from a369a75 to 9e61e0b Compare April 28, 2021 05:42

pz9115 reopened this Apr 28, 2021

pz9115 requested review from jim-wilson and Nelson1225 April 28, 2021 05:53

Fix version ignored set

a068f32

Nelson1225 suggested changes Jun 9, 2021

View reviewed changes

Fix intend problems and update CSR testcases

104733f

Fix intend problems and update CSR testcases, delete the version for k, zkn, zks.

Nelson1225 approved these changes Jun 9, 2021

View reviewed changes

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch from 3b3c319 to 5792217 Compare June 9, 2021 09:06

pz9115 added 2 commits June 9, 2021 18:11

Update the CRS testcases and remove the expand for 'k'

15c2f2b

Update the CRS testcases and remove the expand for 'k',‘zkn’,'zks'.

Update the testcases with csr

1b0cdb6

Update the testcases with csr define.

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch from 5792217 to 15c2f2b Compare June 9, 2021 10:14

pz9115 mentioned this pull request Jun 17, 2021

Update the configure options with binutils change plctlab/plctlab.github.io#16

Merged

Update to spec V0.92

46d796f

pz9115 changed the title ~~Add k-ext support with v0.90~~ Add k-ext support with v0.92 Jun 22, 2021

Update to spec v0.93

5921fb6

Update to spec v0.93, change mentropy into sentropy, update some aes encoding with 'bs', change 'rcon' into 'rnum'.

pz9115 force-pushed the riscv-binutils-2.36-k-ext branch from adffaa1 to 5921fb6 Compare July 1, 2021 09:50

Update the testcases with csr 'sentropy'

7f6077b

pz9115 changed the title ~~Add k-ext support with v0.92~~ Add k-ext support with v0.93 Jul 29, 2021

pz9115 added 2 commits August 5, 2021 17:40

Update the aes32* opcode and csr with spec v0.94

977b6aa

Update the aes32* opcode and csr with spec v0.94.

Update the version number

520f506

pz9115 changed the title ~~Add k-ext support with v0.93~~ Add k-ext support with v0.94 Aug 12, 2021

Update k-ext into v1.0 and merge the zbk* part from bitmanip

87f3860

pz9115 closed this Aug 19, 2021

pz9115 deleted the riscv-binutils-2.36-k-ext branch August 19, 2021 09:09

pz9115 restored the riscv-binutils-2.36-k-ext branch August 23, 2021 09:39

pz9115 reopened this Aug 23, 2021

pz9115 changed the title ~~Add k-ext support with v0.94~~ Add k-ext support with v1.0.0-rc Aug 23, 2021

pz9115 requested a review from Nelson1225 August 23, 2021 09:47

This was referenced Aug 23, 2021

Add remaining b-ext insns #255

Closed

k-ext 后续开发任务 plctlab/riscv-gnu-toolchain#12

Closed

b-ext 开发计划 plctlab/riscv-gnu-toolchain#14

Closed

Update with spec 1.0.0-rc4

7278212

Update with spec 1.0.0-rc4

pz9115 closed this Jun 14, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add k-ext support with v1.0.0-rc #254

Add k-ext support with v1.0.0-rc #254

pz9115 commented Mar 30, 2021

Nelson1225 commented Mar 30, 2021

jim-wilson left a comment

jim-wilson commented Mar 30, 2021

jim-wilson commented Mar 30, 2021

Nelson1225 left a comment •

edited

Loading

Nelson1225 Jun 9, 2021

Nelson1225 Jun 9, 2021

pz9115 Jun 9, 2021

Nelson1225 Jun 9, 2021

pz9115 Jun 9, 2021

Nelson1225 Jun 9, 2021

pz9115 Jun 9, 2021

Nelson1225 commented Jun 9, 2021

Nelson1225 left a comment

Nelson1225 Jun 9, 2021

pz9115 Jun 9, 2021

pz9115 commented Aug 23, 2021

pz9115 commented Jun 14, 2022

Add k-ext support with v1.0.0-rc #254

Add k-ext support with v1.0.0-rc #254

Conversation

pz9115 commented Mar 30, 2021

Nelson1225 commented Mar 30, 2021

jim-wilson left a comment

Choose a reason for hiding this comment

jim-wilson commented Mar 30, 2021

jim-wilson commented Mar 30, 2021

Nelson1225 left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nelson1225 commented Jun 9, 2021

Nelson1225 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pz9115 commented Aug 23, 2021

pz9115 commented Jun 14, 2022

Nelson1225 left a comment •

edited

Loading