Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix store condition: instruction has wrong operand order #11

Merged
merged 1 commit into from Jul 27, 2021

Conversation

zhengxiaolinX
Copy link
Collaborator

@zhengxiaolinX zhengxiaolinX commented Jul 27, 2021

Hi team,

This is a trivial fix for an issue reproduced by using PrintBiasedLockingStatistics. Though this option is getting removed in the next merge and the atomic_incw is only used to atomically set a value of a counter variable currently, I assume this basic function atomic_incw may get remained for future use, so a fix might be needed. Tested in all cases.

Thanks,
Xiaolin

Copy link
Collaborator

@yhzhu20 yhzhu20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@yadongw yadongw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants