Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Target error exit condition #70

Closed
towoe opened this issue Oct 8, 2019 · 2 comments
Closed

Target error exit condition #70

towoe opened this issue Oct 8, 2019 · 2 comments

Comments

@towoe
Copy link
Contributor

towoe commented Oct 8, 2019

I noticed that the tests do not fail immediately if there is an error in $(TARGET_SIM).
So for example in Ibex the termination is done by ; and not &&.
I was just wondering if this a feature so all the other tests are also executed.
If that is the case maybe this can be improved by using && and ignore the error with - in the calling Makefile so it is more obvious in the make output.
Or maybe this is not the intended way. I am happy to create a PR but wanted to check before what the intentions here are.
@allenjbaum
Copy link
Collaborator

I believe the intention is (or should be) to run (or attempt to run) all tests, reporting failures for each. I have seen riscof have this kind of behavior, and it makes it easier to see a class of problems that might be fixed all at once instead of one by one.
Please close this if this answers your issue,

towoe added a commit to towoe/riscv-compliance that referenced this issue Feb 4, 2020
@towoe
Report error in Ibex run target
b7d28e5 
The current output for an error in the execution of the Ibex target is
not reported. All tests are executed and at the verification stage a
difference in the output signatures will result in a failure of the test
case.
As no error of `RUN_TARGET` is produced, it is difficult to investigate
the actual problem.

This change will allow `make` to report an error but continue the
execution of the following tests.
As the output of a test case now shows that an error occurred, it is
easier to find the cause for a failed test if an error happened in the
execution of the target.

Closes riscv-non-isa#70
@towoe towoe mentioned this issue Feb 4, 2020
Closed
@towoe
Copy link
Contributor Author

towoe commented Feb 13, 2020

Following the discussion in #80 (v2 of framework is riscof, change for all cores to be avoided) closing this issue.

@towoe towoe closed this as completed Feb 13, 2020
@towoe towoe mentioned this issue Feb 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Report error in Ibex run target towoe/riscv-compliance
2 participants
@towoe @allenjbaum