Add a preprocessor definitions to indidcate the landing pad labeling … #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scheme
Also add 2 more constant value to let user able to determine the scheme.
Example code:
```c
#ifdef __riscv_landing_pad
#if __riscv_landing_pad == __riscv_landing_pad_simple
...
#elif __riscv_landing_pad == __riscv_landing_pad_func_sig
...
#else
#error "Unknown labeling scheme"
#endif
#endif
```
kito-cheng
force-pushed
the
kitoc/riscv_landing_pad
branch
from
8ab23cf
to
779beee
Compare
mylai-mtk
reviewed
May 14, 2024
riscv-c-api.md
Outdated
Comment on lines
51
to
52
| | __riscv_landing_pad_simple | 1 | Constant value for the simple labeling scheme. | | ||
| | __riscv_landing_pad_func_sig | 2 | Constant value for the function signature based labeling scheme. | |
There was a problem hiding this comment.
| __riscv_landing_pad_simple | 1 | Defined if the "simple" landing pad is in use. Constant value for the simple labeling scheme. |
| __riscv_landing_pad_func_sig | 2 | Defined if the "func_sig" landing pad is in use. Constant value for the function signature based labeling scheme. |
Add some conditions to spare the preprocessor from bloated macros?
There was a problem hiding this comment.
But if we are to limit when these macros are defined, why not just use:
#if defined(__riscv_zicfilp_landing_pad_simple)
...
#elif defined(__riscv_zicfilp_landing_pad_func_sig)
...
#endif? This avoids more new macros, and it's clear when these macros would be defined, and when they would not.
There was a problem hiding this comment.
Updated, but I keep __riscv_zicfilp_landing_pad for now, we could remove that later...if that is not really used in anywhere :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…scheme
Also add 2 more constant value to let user able to determine the scheme.
Example code: