-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question about naming of overloaded policy load functions #232
Comments
Thank you for posting this, I think you have found a miss in the specification (and the generated unit tests). I have just checked the latest upstream LLVM compiler and it is able to compile the following.
I will submit a patch to fix this. Thanks again for checking. |
Seem like GCC has honor the spec...:P |
BTW, __riscv_viota_m_u8mf8_mu is the same. |
Yeah, GCC has strictly followed SPEC: bool can_be_overloaded_p (enum predication_type_index pred) const override .... It seems that I need to remove pred != PRED_TYPE_mu; |
Resolves #232 Signed-off-by: eop Chen <eop.chen@sifive.com>
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Resolves #232 Signed-off-by: eop Chen <eop.chen@sifive.com>
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Base on these: riscv-non-isa/rvv-intrinsic-doc#232 riscv-non-isa/rvv-intrinsic-doc#233 Add _mu C++ overloaded intrinsics for load && viota && vid. Co-authored-by: KuanLin Chen <best124612@gmail.com> gcc/ChangeLog: * config/riscv/riscv-vector-builtins-bases.cc: Add _mu overloaded intrinsics. * config/riscv/riscv-vector-builtins-shapes.cc (struct fault_load_def): Ditto.
Hi,
Why _mu series load intrinsics cannot be overloaded without type in the function name?
In vector_loads_and_stores_functions, __riscv_vle16_v_f16mf4_mu, __riscv_vle16_v_f16mf2_mu, etc., are with type in the function name.
But __riscv_vle16_tumu,__riscv_vle16_tum, etc., are without types in the function name.
Thanks.
The text was updated successfully, but these errors were encountered: