Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode conflict (pollentropy and sha256sig0) #50

Closed
JamesKenneyImperas opened this issue Sep 18, 2020 · 4 comments
Closed

Decode conflict (pollentropy and sha256sig0) #50

JamesKenneyImperas opened this issue Sep 18, 2020 · 4 comments
Assignees
Labels
bug Something isn't working encoding Something about an instruction's encoding.

Comments

@JamesKenneyImperas
Copy link

Although the instruction encodings are only tentative, it looks to me like there is a decode conflict between the pollentropy instruction (with shamtw=0) and sha256sig0:

0000111 00000  rs1   111 rd 0101011 ssha256.sig0
0000111 shamtw 01010 111 rd 0101011 pollentropy

(When shamtw!=0, there are conflicts with other instructions as well.)

@ben-marshall
Copy link
Member

Hi James
You're absolutely right, I'm sorry I should have noted this in an issue. This has been fixed on the dev/next-release branch in this commit, but not merged into main yet. It should be merged in the next 7 days, I've been waiting until any instruction name changes settled down before merging it. I'll close this issue when everything gets merged.
Thanks,
Ben

@ben-marshall ben-marshall self-assigned this Sep 18, 2020
@ben-marshall ben-marshall added bug Something isn't working encoding Something about an instruction's encoding. labels Sep 18, 2020
@JamesKenneyImperas
Copy link
Author

Hi Ben,

Thanks - I can see the correct decode now, so I'll use that.

James

@ben-marshall
Copy link
Member

Hi @JamesKenneyImperas
The relevant commit has been merged into master now. If you're alright to close this, that'd be great. Thanks for pointing it out.
Cheers,
Ben

@JamesKenneyImperas
Copy link
Author

Now fixed - closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working encoding Something about an instruction's encoding.
Projects
None yet
Development

No branches or pull requests

2 participants