Skip to content

Commit

Permalink
drop support for locally hosted packages
Browse files Browse the repository at this point in the history
  • Loading branch information
riscy committed Mar 17, 2020
1 parent 70f0190 commit ecc2174
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 19 deletions.
6 changes: 0 additions & 6 deletions README.org
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,6 @@ foolproof, sometimes opinionated, and may raise false positives.
#+begin_src bash
MELPA_PR_URL=https://github.com/melpa/melpa/pull/6718 make
#+end_src
*** Test a local package (work in progress)
#+begin_src bash
PKG_PATH=/path/to/package \
PKG_NAME=package-name \
make
#+end_src
*** Run in an unending loop
This currently only works in macOS; it monitors the clipboard
for new MELPA PR's, then automatically runs the checks on them.
Expand Down
13 changes: 0 additions & 13 deletions melpazoid/melpazoid.py
Original file line number Diff line number Diff line change
Expand Up @@ -523,16 +523,6 @@ def _branch(recipe: str) -> str:
return tokenized_recipe[tokenized_recipe.index(':branch') + 1].strip('"')


def check_local_package(elisp_dir: str = None, package_name: str = None):
"""Check a locally-hosted package (WIP)."""
return_code(0)
elisp_dir = elisp_dir or input('Path: ').strip()
assert os.path.isdir(elisp_dir)
package_name = package_name or input(f"Name of package at {elisp_dir}: ")
recipe = f'({package_name or "NONAME"} :repo "N/A")'
run_checks(recipe, elisp_dir)


def check_melpa_pr(pr_url: str):
"""Check a PR on MELPA."""
return_code(0)
Expand Down Expand Up @@ -690,9 +680,6 @@ def _fetch_pull_requests() -> Iterator[str]:
if 'MELPA_PR_URL' in os.environ:
check_melpa_pr(os.environ['MELPA_PR_URL'])
sys.exit(return_code())
elif 'PKG_PATH' in os.environ and 'PKG_NAME' in os.environ:
check_local_package(os.environ['PKG_PATH'], os.environ['PKG_NAME'])
sys.exit(return_code())
elif 'RECIPE' in os.environ:
check_recipe(os.environ['RECIPE'])
sys.exit(return_code())
Expand Down

2 comments on commit ecc2174

@dickmao
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering why this must be.

@riscy
Copy link
Owner Author

@riscy riscy commented on ecc2174 Apr 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ripped that out because it wasn't sure it was working 100% correctly. It sounds like there's interest in bringing it back in and completing the implementation, so I'll happily raise an issue for that.

Please sign in to comment.