Issue 55/separate maskable icon file #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added ability to specify a separate 'maskable' icon.
This allows developers to create a combination of PWA icons suitable for their applications:
Tested locally using npm link and checked generated manifest.json using manifest-validator. Scenarios tested:
{ icon: 'static/icon.png' }
Expected: Manifest contains array of 'any' icons.
Expected: dist/assets/static contains single set of icons.
Result: As expected
{ icon: 'static/icon.png', maskableIcon: false }
Expected: Manifest contains array of 'any' icons.
Expected: dist/assets/static contains single set of icons.
Result: As expected
{ icon: 'static/icon.png', maskableIcon: true }
Expected: Manifest contains array of 'maskable any' icons.
Expected: dist/assets/static contains single set of icons.
Result: As expected
{ icon: 'static/icon.png', maskableIcon: 'static/icon.png' }
Expected: Manifest contains array of 'maskable any' icons.
Expected: dist/assets/static contains single set of icons.
Result: As expected
{ icon: 'static/icon.png', maskableIcon: 'static/icon-maskable.png' }
Expected: Manifest contains array of 'any' and 'maskable' icons.
Expected: dist/assets/static contains two sets of icons (maskable, any).
Result: As expected