Merge pull request #2 from sarthakjdev/acl-setting-fix

fix: object acl setup permission for object writer issue fixed by enabling the public access.
rishabhrao · May 7, 2023 · 50a6940 · 50a6940
2 parents a2660e0 + 7bb5894
commit 50a6940
Show file tree

Hide file tree

Showing 6 changed files with 48 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1,2 +1,3 @@
 node_modules
 .DS_Store
+.env
diff --git a/dist/index.js b/dist/index.js
@@ -8479,6 +8479,15 @@ exports.default = (bucketName, uploadDirectory, environmentPrefix) => __awaiter(
                 ]
             }
         }).promise();
+        yield s3Client_1.default.putPublicAccessBlock({
+            Bucket: bucketName,
+            PublicAccessBlockConfiguration: {
+                BlockPublicAcls: false,
+                BlockPublicPolicy: false,
+                IgnorePublicAcls: false,
+                RestrictPublicBuckets: false
+            }
+        }).promise();
         console.log('Configuring bucket website...');
         yield s3Client_1.default.putBucketWebsite({
             Bucket: bucketName,
@@ -10121,6 +10130,7 @@ exports.default = (bucketName) => __awaiter(void 0, void 0, void 0, function* ()
         return true;
     }
     catch (e) {
+        console.log(e);
         return false;
     }
 });
@@ -10199,6 +10209,15 @@ exports.default = (bucketName, uploadDirectory, environmentPrefix) => __awaiter(
                 ]
             }
         }).promise();
+        yield s3Client_1.default.putPublicAccessBlock({
+            Bucket: bucketName,
+            PublicAccessBlockConfiguration: {
+                BlockPublicAcls: false,
+                BlockPublicPolicy: false,
+                IgnorePublicAcls: false,
+                RestrictPublicBuckets: false
+            }
+        }).promise();
         console.log('Configuring bucket website...');
         yield s3Client_1.default.putBucketWebsite({
             Bucket: bucketName,
@@ -26359,16 +26378,18 @@ exports.default = (bucketName, directory) => __awaiter(void 0, void 0, void 0, f
         try {
             const fileBuffer = yield fs_1.promises.readFile(filePath);
             const mimeType = mime_types_1.default.lookup(filePath) || 'application/octet-stream';
-            yield s3Client_1.default.putObject({
+            const response = yield s3Client_1.default.putObject({
                 Bucket: bucketName,
                 Key: s3Key,
                 Body: fileBuffer,
                 ACL: 'public-read',
                 ServerSideEncryption: 'AES256',
                 ContentType: mimeType
             }).promise();
+            console.log({ response });
         }
         catch (e) {
+            console.log(e);
             const message = `Failed to upload ${s3Key}: ${e.code} - ${e.message}`;
             console.log(message);
             throw message;

diff --git a/src/actions/prUpdatedAction.ts b/src/actions/prUpdatedAction.ts
@@ -36,6 +36,16 @@ export default async (bucketName: string, uploadDirectory: string, environmentPr
 			}
 		}).promise()
 
+		await S3.putPublicAccessBlock({
+			Bucket: bucketName,
+			PublicAccessBlockConfiguration: {
+				BlockPublicAcls: false,
+				BlockPublicPolicy: false,
+				IgnorePublicAcls: false,
+				RestrictPublicBuckets: false
+			}
+		}).promise()
+
 		console.log('Configuring bucket website...')
 		await S3.putBucketWebsite({
 			Bucket: bucketName,

diff --git a/src/actions/uploadAction.ts b/src/actions/uploadAction.ts
@@ -35,6 +35,16 @@ export default async (bucketName: string, uploadDirectory: string, environmentPr
 			}
 		}).promise()
 
+		await S3.putPublicAccessBlock({
+			Bucket: bucketName,
+			PublicAccessBlockConfiguration: {
+				BlockPublicAcls: false,
+				BlockPublicPolicy: false,
+				IgnorePublicAcls: false,
+				RestrictPublicBuckets: false
+			}
+		}).promise()
+
 		console.log('Configuring bucket website...')
 		await S3.putBucketWebsite({
 			Bucket: bucketName,

diff --git a/src/utils/checkBucketExists.ts b/src/utils/checkBucketExists.ts
@@ -5,6 +5,7 @@ export default async (bucketName: string) => {
 		await S3.headBucket({ Bucket: bucketName }).promise()
 		return true
 	} catch (e) {
+		console.log(e)
 		return false
 	}
 }
diff --git a/src/utils/s3UploadDirectory.ts b/src/utils/s3UploadDirectory.ts
@@ -20,15 +20,18 @@ export default async (bucketName: string, directory: string) => {
 				const fileBuffer = await fs.readFile(filePath)
 				const mimeType = mimeTypes.lookup(filePath) || 'application/octet-stream'
 
-				await S3.putObject({
+				const response = await S3.putObject({
 					Bucket: bucketName,
 					Key: s3Key,
 					Body: fileBuffer,
 					ACL: 'public-read',
 					ServerSideEncryption: 'AES256',
 					ContentType: mimeType
 				}).promise()
+
+				console.log({ response })
 			} catch (e) {
+				console.log(e)
 				const message = `Failed to upload ${s3Key}: ${e.code} - ${e.message}`
 				console.log(message)
 				throw message