Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support sorted flush to disk #113

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented Nov 8, 2021

Signed-off-by: Alex Chi iskyzh@gmail.com

In this PR, we added is_sorted to txn's scan option, though not supported for now. And when flushing data to disk, it will now be automatically sorted by the primary key.

ref #114

Signed-off-by: Alex Chi <iskyzh@gmail.com>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangrunji0408 wangrunji0408 merged commit 777ed99 into main Nov 8, 2021
@wangrunji0408 wangrunji0408 deleted the skyzh/sorted-flush branch November 8, 2021 04:54
Copy link
Contributor

@zehaowei zehaowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skyzh skyzh mentioned this pull request Nov 8, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants