Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): add BTreeMap for row-format memory table #150

Merged
merged 4 commits into from
Nov 19, 2021
Merged

feat(storage): add BTreeMap for row-format memory table #150

merged 4 commits into from
Nov 19, 2021

Conversation

zehaowei
Copy link
Contributor

@zehaowei zehaowei commented Nov 19, 2021 •
edited by skyzh

Solve this issue
close #98

Use BTreeMap for sorted row-format memory table

skyzh
skyzh reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM, good work!

src/storage/secondary/rowset/mem_rowset.rs Outdated Show resolved Hide resolved
src/storage/secondary/rowset/mem_rowset.rs Outdated Show resolved Hide resolved
src/storage/secondary/rowset/mem_rowset.rs Outdated Show resolved Hide resolved
src/storage/secondary/rowset/mem_rowset.rs Outdated Show resolved Hide resolved
src/storage/secondary/rowset/mem_rowset.rs Outdated Show resolved Hide resolved
src/types/mod.rs Outdated Show resolved Hide resolved
@skyzh
Copy link
Member

skyzh commented Nov 19, 2021

Please run cargo fmt and cargo clippy before merging :)

skyzh
skyzh approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@skyzh skyzh merged commit dbd0120 into main Nov 19, 2021
@skyzh skyzh deleted the zehao/memory_row_format branch November 19, 2021 09:59
@zehaowei zehaowei self-assigned this Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@MingjiHan99 MingjiHan99 Awaiting requested review from MingjiHan99

@wangrunji0408 wangrunji0408 Awaiting requested review from wangrunji0408

Assignees

@zehaowei zehaowei

Labels
archived
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

storage: in-memory row format (and sort key support)
3 participants
@zehaowei @skyzh @neverchanje