feat(storage): Add filter in rowset_iterator #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyzh
reviewed
Jan 5, 2022
likg227
force-pushed
the
lkg/rowset-iterator
branch
from
ecacac0
to
9ceda4a
Compare
skyzh
reviewed
Jan 6, 2022
likg227
force-pushed
the
lkg/rowset-iterator
branch
from
6b07f89
to
8ae0e01
Compare
skyzh
approved these changes
Jan 7, 2022
src/storage/chunk.rs
Outdated
| @@ -51,6 +51,7 @@ impl StorageChunk { | |||
| cardinality, | |||
| }) | |||
| } else { | |||
| println!("construct() returned None"); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #190
close #191