test: auto discover test cases from path #376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
skyzh
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
LGTM, good work!
- Should also update and test docs/tpch.md. In that, we used
create.slt. As.sltnow has different suffix, the rising light binary will regard it as SQL. Need some changes. - Should update
contributing.mdso that new developers know that.sltwill be automatically picked up.
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
|
I have changed the ignore pattern from |
skyzh
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the rest of
basic_test.sltand a part ofselect.slt(#350) tests.This also resolves #338: automatically discover test cases from path, by generating source file in build.rs.
Note that there is a test
statistics.sltthat fails on in-memory storage, it has been added to the blocklist in build.rs.