feat: support where clause #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix a bug in table deletion
skyzh
reviewed
Sep 29, 2021
| pub fn array_at(&self, idx: usize) -> &ArrayImpl { | ||
| &self.arrays[idx] | ||
| } | ||
|
|
||
| pub fn filter(&self, visibility: impl Iterator<Item = bool> + Clone) -> Self { |
There was a problem hiding this comment.
It is a little bit weird to + Clone on Iterator. I'm in favor of using &[bool] or &Bitmap for visibility.
There was a problem hiding this comment.
Actually the input of visibility is a PrimitiveArray<bool>. We can't get &[bool] or &Bitmap without additional memory allocation(
skyzh
approved these changes
Sep 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for SQL
whereclause, including:For simplicity, the
visibilityfield was removed from theDataChunkstruct. Instead, we provide afiltermethod to generate new array(chunk) directly.