fix(executor): limit should exit early when offset and limit are both 0 #506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #264
The issue can be reproduced using memory engine like this: (Btw, the sqlogictest fails for both disk & memory engines)
The execution process is
Because when
offset=limit=0
,start=end=0
, and thus it willcontinue
.risinglight/src/executor/limit.rs
Lines 27 to 32 in fea5e0b