storage: use Arc<Version> during pin and unpin #549
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yisaer <disxiaofei@163.com>
skyzh
reviewed
Mar 8, 2022
There was a problem hiding this comment.
Rest LGTM, thanks!
I've another idea: we can simply using Arc to help us do reference counting, instead of maintaining the ref_cnt by ourselves. For each epoch, we associate a single Version object, and wrap it with an Arc. When a user requests pin, we clone the Arc for them. When the last Arc gets dropped, the Version object gets dropped, and we can safely remove the version.
| @@ -70,15 +67,15 @@ impl SecondaryTransaction { | |||
| update: bool, | |||
| ) -> StorageResult<Self> { | |||
| // pin a snapshot at version manager | |||
| let (epoch, snapshot) = table.version.pin(); | |||
| let version = table.version.pin(); | |||
There was a problem hiding this comment.
Should store version inside txn struct, otherwise it will get immediately unpinned once txn is created.
|
solved by #685 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yisaer disxiaofei@163.com
close #537
Currently, we use
pinandunpinmanually in code. In this request, we useArc<Version>to help us automatically unpin instead of manual code.