Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: do not detect tests in build.rs #564

Merged
merged 3 commits into from
Mar 15, 2022
Merged

test: do not detect tests in build.rs #564

merged 3 commits into from
Mar 15, 2022

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Mar 15, 2022

Signed-off-by: xxchan xxchan22f@gmail.com

in sqllogictest.rs instead

closes #472

@xxchan
do not detect tests in build.rs
612574c 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan enabled auto-merge (squash) March 15, 2022 13:17
@xxchan xxchan changed the title do not detect tests in build.rs test: do not detect tests in build.rs Mar 15, 2022
@xxchan
fmt
e540e0b 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan
clippy
b117ebc 
Signed-off-by: xxchan <xxchan22f@gmail.com>
@xxchan xxchan requested a review from arkbriar March 15, 2022 13:35
skyzh
skyzh approved these changes Mar 15, 2022
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'd prefer tests could be running in parallel and test names can be shown in stdout...

@xxchan xxchan merged commit 3ceb274 into main Mar 15, 2022
@xxchan xxchan deleted the no branch March 15, 2022 13:46
@skyzh
Copy link
Member

skyzh commented Mar 15, 2022

Also test CI is running significantly slower than before, 4m50s -> 6m

@xxchan xxchan mentioned this pull request Mar 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

@wangrunji0408 wangrunji0408 Awaiting requested review from wangrunji0408

@arkbriar arkbriar Awaiting requested review from arkbriar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tests: small change in tests folder will cause a full rebuild of binary
2 participants
@xxchan @skyzh