binder: primary key should by-default be non-null #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yangjiang <yangjiang@ebay.com>
|
cc @shmiwy now the pk won't be nullable any more. I guess this would make things easier on storage layer. |
chowc
pushed a commit
to chowc/risinglight
that referenced
this pull request
May 18, 2022
* binder: primary key should by-default be non-null Signed-off-by: yangjiang <yangjiang@ebay.com> * fix ut Signed-off-by: yangjiang <yangjiang@ebay.com> Signed-off-by: johnyzhou <johnyzhou@tencent.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first pr to this repo 馃榿锛孖f there are something i miss plz fell free to tell me.
close #632