Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sqllogictest): use libtest-mimic as test harness #656

Merged
merged 4 commits into from
May 27, 2022

Conversation

skyzh
Copy link
Member

@skyzh skyzh commented May 27, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

image

nextest will automatically pick up binaries in libtest-mimic, so we won't need complex build.rs any more!

ref #472

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from wangrunji0408 May 27, 2022 14:23
Signed-off-by: Alex Chi <iskyzh@gmail.com>
Copy link
Member

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks cool!

skyzh added 2 commits May 28, 2022 00:13
Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh enabled auto-merge (squash) May 27, 2022 16:14
@skyzh skyzh merged commit b05d98d into main May 27, 2022
@skyzh skyzh deleted the skyzh/use-nextest-harness branch May 27, 2022 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants