Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: append NULLs when inserting value with incomplete columns #673

Merged
merged 1 commit into from
Jul 22, 2022
Merged

fix: append NULLs when inserting value with incomplete columns #673

merged 1 commit into from
Jul 22, 2022

Conversation

GoGim1
Copy link
Contributor

@GoGim1 GoGim1 commented Jul 22, 2022

close #669

Signed-off-by: gogim1 294843472@qq.com

@GoGim1
fix: non-null column does not appear in the list of values
c3d7664 
Signed-off-by: gogim1 <294843472@qq.com>
xxchan
xxchan approved these changes Jul 22, 2022
View reviewed changes
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. BTW, the panic also happens for null column. I think the title should be "fix: append NULLs when inserting value with incomplete columns"?

@GoGim1 GoGim1 changed the title fix: panicked when a non-null column does not appear in the list of values fix: append NULLs when inserting value with incomplete columns Jul 22, 2022
@xxchan xxchan merged commit a1f078b into risinglightdb:main Jul 22, 2022
@GoGim1 GoGim1 deleted the issue669 branch July 22, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xxchan xxchan xxchan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: panicked when a non-null column does not appear in the list of values
2 participants
@GoGim1 @xxchan