Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(storage): support dict encoding in primitive column builder #701

Merged
merged 2 commits into from
Oct 3, 2022
Merged

feat(storage): support dict encoding in primitive column builder #701

merged 2 commits into from
Oct 3, 2022

Conversation

Kikkon
Copy link
Contributor

@Kikkon Kikkon commented Oct 3, 2022 •
edited
Loading

馃ぃ #670 has been completed in issue #699, so we can support dict-encoding in primitive column builder.

@Kikkon
Copy link
Contributor Author

Kikkon commented Oct 3, 2022

and fixed issue #679 by the way

skyzh
skyzh approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also help switch compaction to use dict instead of RLE when number of distinct value is low? Thanks!

@Kikkon
Copy link
Contributor Author

Kikkon commented Oct 3, 2022

Can you also help switch compaction to use dict instead of RLE when number of distinct value is low? Thanks!

Sounds good, let me take a look. I propose another PR to solve #674

@skyzh skyzh merged commit bb3498f into risinglightdb:main Oct 3, 2022
@Kikkon Kikkon deleted the kikkon/dict branch October 4, 2022 08:44
@unconsolable unconsolable mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kikkon @skyzh