Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(storage): replace primitive nullable encoding with generic way #713

Merged
merged 2 commits into from
Oct 23, 2022
Merged

refactor(storage): replace primitive nullable encoding with generic way #713

merged 2 commits into from
Oct 23, 2022

Conversation

unconsolable
Copy link
Member

@unconsolable unconsolable commented Oct 15, 2022 •
edited
Loading

Signed-off-by: unconsolable chenzhipeng2012@gmail.com

  • Refactor variable names in NullableBlockBuilder and NullableBlockIterator
  • Add new fn in trait NonNullableBlockBuilder to make NullableBlockBuilder::should_finish more precise
  • Replace primitive nullable encoding in tests, PrimitiveColumnBuilder and PrimitiveColumnFactory

close #712

@unconsolable
refactor(storage): replace primitive nullable encoding with generic way
36a3e5f 
Signed-off-by: unconsolable <chenzhipeng2012@gmail.com>
@skyzh skyzh self-requested a review October 16, 2022 01:49
@skyzh skyzh enabled auto-merge (squash) October 23, 2022 15:14
@skyzh skyzh disabled auto-merge October 23, 2022 15:14
@skyzh skyzh enabled auto-merge (squash) October 23, 2022 15:14
@skyzh skyzh merged commit 5621672 into risinglightdb:main Oct 23, 2022
@unconsolable unconsolable deleted the replace-primitive branch October 24, 2022 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace primitive nullable encoding with generic nullable encoding
2 participants
@unconsolable @skyzh