Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(fetch size): add fast return and compare ROWSET MAX OUTPUT #716

Merged
merged 3 commits into from
Nov 8, 2022
Merged

refactor(fetch size): add fast return and compare ROWSET MAX OUTPUT #716

merged 3 commits into from
Nov 8, 2022

Conversation

eliasyaoyc
Copy link
Contributor

Fast return: when all columns size is 0, only has tow case:

  1. index of current block is no data can fetch (use ROWSET_MAX_OUTPUT).
  2. all columns is finished (return directly).
    (old code, if all columns is finished then return 0 and io will occur.)

Signed-off-by: Elias.Yao siran0611@gmail.com

@eliasyaoyc
refactor(fetch size): add fast return and compare ROWSET MAX OUTPUT
8ffdb8f 
Signed-off-by: Elias.Yao <siran0611@gmail.com>
@eliasyaoyc
refactor(fetch size): adjust is_finished code.
8daaeca 
Signed-off-by: Elias.Yao <siran0611@gmail.com>
@skyzh
Copy link
Member

skyzh commented Nov 2, 2022

Will come back and take a look soon. Sorry for the delay.

@skyzh skyzh enabled auto-merge (squash) November 8, 2022 03:29
@skyzh skyzh merged commit 2bedd78 into risinglightdb:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skyzh skyzh skyzh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eliasyaoyc @skyzh