Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support TPC-H Q9 #761

Merged
merged 10 commits into from
Jan 10, 2023
Merged

feat: support TPC-H Q9 #761

merged 10 commits into from
Jan 10, 2023

Conversation

wangrunji0408
Copy link
Member

@wangrunji0408 wangrunji0408 commented Jan 7, 2023

With subquery support in #756, we are able to challenge more TPC-H queries.
As an example, this PR adds support for TPC-H Q9.

Changes:

  • support like operator
  • support extract(year from xx) function
  • update sqlparser-rs version to 0.30 (for derivingOrd)
  • add TPC-H Q9 to test

However, the speed for this query is ridiculously slow. (104s vs DuckDB <1s)
We should investigate and optimize it in the future.

Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Copy link
Collaborator

@MingjiHan99 MingjiHan99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 enabled auto-merge (squash) January 9, 2023 15:51
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Q9 contains a lot of joins, and I guess we need to see if the join order is not optimal.

@wangrunji0408
Copy link
Member Author

wangrunji0408 commented Jan 10, 2023

Any idea about the failing CI? I can't get the point from the error message: 🥵

The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
The operation was canceled.

@skyzh
Copy link
Member

skyzh commented Jan 10, 2023

I guess it’s OOM or something…

@wangrunji0408
Copy link
Member Author

I believe it's OOM because it consumes 16GB on my Mac.
Let's skip it on CI. 🥵

Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 merged commit 857159e into main Jan 10, 2023
@wangrunji0408 wangrunji0408 deleted the wrj/tpch-q9 branch January 10, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants