Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable types follow up: complete types in update_test_file #164

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

melgenek
Copy link
Contributor

This pr introduced a way to use custom column types #160.
But the completion code kept ignoring the types.

This pr updates the implementation to complete column types the same way results are completed.

Signed-off-by: Yevhenii Melnyk <melnyk.yevhenii@gmail.com>
Signed-off-by: Yevhenii Melnyk <melnyk.yevhenii@gmail.com>
Signed-off-by: Yevhenii Melnyk <melnyk.yevhenii@gmail.com>
Copy link
Member

@skyzh skyzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@skyzh
Copy link
Member

skyzh commented Feb 15, 2023

reminder to myself: next time we should highlight the runner is now using strict validator in release log

@skyzh skyzh merged commit 30b83ff into risinglightdb:main Feb 15, 2023
@skyzh
Copy link
Member

skyzh commented Feb 15, 2023

I'll release a new version tomorrow :)

@melgenek
Copy link
Contributor Author

@skyzh Thank you!

reminder to myself: next time we should highlight the runner is now using strict validator in release log

I'd say the changes are:

  • sqllogictest-bin uses the strict validator to update records
  • but the default runner doesn't check columns by default
  • The query syntax now allows optional columns, so this record is valid now
query
select * from table;
----
1
2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants