feat: support multiple connections (sessions) in a single test file #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wangrunji0408 @xxchan @skyzh Would you please help to review this? 🥰 |
BugenZhao
commented
Jul 5, 2023
8 tasks
xxchan
reviewed
Jul 10, 2023
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## [0.15.0] - 2023-07-06 | ||
|
|
||
| * Allow multiple connections to the database in a single test case, which is useful for testing the transaction behavior. This can be achieved by attaching a `connection foo` record before the query or statement. |
There was a problem hiding this comment.
Can you add an example transaction test? Maybe use Postgres
There was a problem hiding this comment.
Oh, but currently our CI doesn't have Postgres
There was a problem hiding this comment.
But it's ok even if it's only tested locally.
There was a problem hiding this comment.
There's an example that basically shows how it works.
There was a problem hiding this comment.
Yes I see it, but I mean a more “real” one 😄
There was a problem hiding this comment.
Ok. Let's add a comprehensive set of tests for the engines crate in the future.
xxchan
reviewed
Jul 10, 2023
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
|
All comments resolved. Please take a look again. 🥰 |
xxchan
approved these changes
Jul 11, 2023
|
new version published |
Merged
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao i@bugenzhao.com
DuckDB's sqllogictest implementation provides the ability for establishing multiple connections in an
sltfile and specify which to use for each query or statement, which is helpful for testing database transactions.This PR implements a similar feature, except that we will use a line
connection <name>instead of the DuckDB's syntax since it is already utilized by our error matching feature.This is a breaking change to the interfaces of the library crate (like
Runner::new), so maybe we need to bump the minor version under0.