-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc Doris sink #1349
Doc Doris sink #1349
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
@xxhZs Is there a data type mapping table that we can include? |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@emile-00 Please make sure to include the data mapping table in the topic. Thanks. |
Here, it may be necessary to emphasize the length and precision issues of decimal, similar to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Info
Description
Doc Doris sink, edit some typos in Clickhouse guide.
Notes
[ Include any supplementary context or references here. ]
Related code PR
feat(sink): support doris sink risingwave#12336
Related doc issue
Resolves Document: feat(sink): support doris sink #1328
For reviewers
Preview
[ Paste the preview link to the updated page(s) here. Edit this item after the preview site is ready. To find the updated pages, scroll down to locate and open the Amplify preview link and select the upcoming version of the documentation. ]
Key points
[ Parts that may need revision or extra consideration. ]
Before merging
I have checked the doc site preview, and the updated parts look good.
I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (
CharlieSYH
,emile-00
, &hengm3467
).