Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc Doris sink #1349

Merged
merged 3 commits into from
Oct 13, 2023
Merged

Doc Doris sink #1349

merged 3 commits into from
Oct 13, 2023

Conversation

emile-00
Copy link
Contributor

@emile-00 emile-00 commented Oct 4, 2023

Info

For reviewers

  • Preview

    [ Paste the preview link to the updated page(s) here. Edit this item after the preview site is ready. To find the updated pages, scroll down to locate and open the Amplify preview link and select the upcoming version of the documentation. ]

  • Key points

    [ Parts that may need revision or extra consideration. ]

Before merging

  • I have checked the doc site preview, and the updated parts look good.

  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (CharlieSYH, emile-00, & hengm3467).

@aws-amplify-us-east-1
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1349.d2fbku9n2b6wde.amplifyapp.com

@emile-00
Copy link
Contributor Author

emile-00 commented Oct 4, 2023

@xxhZs Is there a data type mapping table that we can include?

@xxhZs
Copy link
Contributor

xxhZs commented Oct 8, 2023

@xxhZs Is there a data type mapping table that we can include?
risingwave = > doris
Boolean => BOOLEAN,
smallint=> SMALLINT,
integer=> INT,
bigint=> BIGINT,
real=>FLOAT
double => DOUBLE
Decimal =>DECIMAL
Date => DATE
Varchar =>STRING, VARCHAR
Time => not support
timestamp without time zone => DATETIME
timestamp with time zone=> not support
Interval =>not support
Struct => STRUCT
array => ARRAY
Bytea => not support
Jsonb => JSONB,
Serial => BIGINT

Copy link
Collaborator

@hengm3467 hengm3467 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@hengm3467
Copy link
Collaborator

@emile-00 Please make sure to include the data mapping table in the topic. Thanks.

@xxhZs
Copy link
Contributor

xxhZs commented Oct 8, 2023

@xxhZs Is there a data type mapping table that we can include?
risingwave = > doris
Boolean => BOOLEAN,
smallint=> SMALLINT,
integer=> INT,
bigint=> BIGINT,
real=>FLOAT
double => DOUBLE
Decimal =>DECIMAL
Date => DATE
Varchar =>STRING, VARCHAR
Time => not support
timestamp without time zone => DATETIME
timestamp with time zone=> not support
Interval =>not support
Struct => STRUCT
array => ARRAY
Bytea => not support
Jsonb => JSONB,
Serial => BIGINT

Here, it may be necessary to emphasize the length and precision issues of decimal, similar to:
"1. RW will round to the nearest to ensure precision matches that of Doris. 2. Please ensure that the length of decimal types being imported into Doris does not exceed Doris's decimal length, otherwise it will fail to import."

Copy link
Contributor

@xxhZs xxhZs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hengm3467 hengm3467 merged commit b2528f9 into main Oct 13, 2023
3 checks passed
@hengm3467 hengm3467 deleted the doc-doris-sink branch October 13, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat(sink): support doris sink
3 participants