Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add on conflict clause in create table statement #1860

Open
wants to merge 20 commits into
base: main
Choose a base branch
from

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Feb 20, 2024

Info

It is NOT implemented yet and just to define the behavior and confirm the requirement with users before implementation

  • Description

    • [ What's changed? Which parts of the docs are affected? ]
  • Notes

    • [ Include any supplementary context or references here. ]
  • Related code PR

    • [ Provide a link to the relevant code PR here, if applicable. ]
  • Related doc issue

    Resolves [ Provide a link to the relevant doc issue here, if applicable. ]

For reviewers

  • Preview

    • [ Paste the preview link to the updated page(s) here. Edit this item after the preview site is ready. To find the updated pages, scroll down to locate and open the Amplify preview link and select the dev version of the documentation. ]
  • Key points

    • [ Parts that may need revision or extra consideration. ]

Before merging

  • I have checked the doc site preview, and the updated parts look good.

  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (CharlieSYH, emile-00, & hengm3467).

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1860.d2fbku9n2b6wde.amplifyapp.com

---
id: multiple-sink-into-table
slug: /multiple-sink-into-table
title: multiple-sink-into-table
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: multiple-sink-into-table
title: Multiple Sink into table

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides, regarding of terminology, how about call it "Table sink" among our docs? We usually say "sink into table" but this sounds like a verb word rather than noun.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've already used "sink" as a verb in almost all sink docs 😂

docs/transform/multiple-sink-into-table.md Outdated Show resolved Hide resolved
docs/transform/multiple-sink-into-table.md Outdated Show resolved Hide resolved
docs/transform/multiple-sink-into-table.md Outdated Show resolved Hide resolved
st1page and others added 2 commits February 23, 2024 12:46
Co-authored-by: Eric Fu <eric@singularity-data.com>
@st1page st1page changed the title add on conflict clause in create table statement WIP: add on conflict clause in create table statement Apr 7, 2024
@neverchanje
Copy link
Contributor

We may consider tagging it a beta feature if we are not much confident about the design.

@yezizp2012
Copy link
Contributor

Any updates? 👀 We have received some feature requests from customers and community. Better to make it visible in our docs.

@st1page
Copy link
Contributor Author

st1page commented Jun 18, 2024

Excluding the contentious "version column" part, I believe the remainder has been released in version 1.9. PTAL @neverchanje

@st1page st1page marked this pull request as ready for review June 18, 2024 06:27
@st1page st1page changed the title WIP: add on conflict clause in create table statement add on conflict clause in create table statement Jun 24, 2024
Copy link
Contributor

@WanYixian WanYixian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the language review and LGTM now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants