Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc non-append-only process-time temporal join #2136

Conversation

WanYixian
Copy link
Contributor

Info

For reviewers

  • Preview

    • [ Paste the preview link to the updated page(s) here. Edit this item after the preview site is ready. To find the updated pages, scroll down to locate and open the Amplify preview link and select the dev version of the documentation. ]
  • Key points

    • [ Parts that may need revision or extra consideration. ]

Before merging

  • I have checked the doc site preview, and the updated parts look good.

  • I have acquired the approval from the owner (and optionally the reviewers) of the code PR and at least one tech writer (CharlieSYH, emile-00, & hengm3467).

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2136.d2fbku9n2b6wde.amplifyapp.com

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that the sql of temporal join should be changed from:

SELECT transaction_id, product_id, quantity, sale_date, product_name, price 
FROM sales
JOIN products FOR SYSTEM_TIME AS OF PROCTIME()
ON product_id = id

to :

SELECT transaction_id, product_id, quantity, sale_date, product_name, price 
FROM sales
JOIN products FOR SYSTEM_TIME AS OF PROCTIME()
ON product_id = id where process_time between valid_from and valid_to

Copy link
Contributor

@ShanlanLi ShanlanLi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement below may lack a ";":
image

@WanYixian WanYixian merged commit 4489465 into main May 8, 2024
3 checks passed
@WanYixian WanYixian deleted the 2086-document-featstream-support-non-append-only-process-time-temporal-join branch May 8, 2024 04:35
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document: feat(stream): support non-append-only process time temporal join
3 participants