-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(crd): rewrite the RisingWave and the controller #109
Conversation
Signed-off-by: arkbriar <arkbriar@gmail.com>
d4c4967
to
07b6124
Compare
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
…e golangci-lint Signed-off-by: arkbriar <arkbriar@gmail.com>
…tus; remove useless default values from CRD Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar <arkbriar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM! Do you have tested on AWS cluster? I suggest testing it on local cluster and AWS cluster.
``` | ||
|
||
If you edit the `ConfigMap`, please restart the `risingwave-operator` to reload the configuration. | ||
|
||
## Monitoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the Monitoring
part?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's generally not telling the truth, so I think it should be removed for now, especially the service monitor part. We can add it back to the readme after implementing it.
Signed-off-by: arkbriar <arkbriar@gmail.com>
Signed-off-by: arkbriar arkbriar@gmail.com
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
RisingWave
and add a new CRRisingWavePodTemplate
RisingWavePodTemplate
to ensure immutabilitylegacy
directorycontroller-gen
to 0.9.2 to fix an issuectrlkit-gen
to latest to fix an issueapis
package in the outside packageall
andstreaming
Now you can view the
RisingWave
related resources with the following command:Guidance to review:
apis/risingwave/v1alpha1
pkg/factory
pkg/manager
Checklist
Refer to a related PR or issue link (optional)