fix: set prefix_hint to none when prefix_hint_len is zero

risingwavelabs · Feb 18, 2023 · 0fa766e · 0fa766e
1 parent 03c26b0
commit 0fa766e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/stream/src/common/table/state_table.rs b/src/stream/src/common/table/state_table.rs
@@ -1107,7 +1107,7 @@ impl<S: StateStore, W: WatermarkBufferStrategy> StateTable<S, W> {
         }
         let prefix_hint = {
             if self.prefix_hint_len == 0 || self.prefix_hint_len > pk_prefix.len() {
-                panic!();
+                None
             } else {
                 let encoded_prefix_len = self
                     .pk_serde

diff --git a/src/stream/src/executor/managed_state/join/mod.rs b/src/stream/src/executor/managed_state/join/mod.rs
@@ -432,7 +432,7 @@ impl<K: HashKey, S: StateStore> JoinHashMap<K, S> {
         } else {
             let prefix = key.deserialize(&self.join_key_data_types)?;
             self.metrics.insert_cache_miss_count += 1;
-            // Refill cache when the join key exist in neither cache or storage.
+            // Refill cache when the join key exists in neither cache or storage.
             if !self.state.table.may_exist(&prefix).await? {
                 let mut state = JoinEntryState::default();
                 state.insert(pk, value.encode());
@@ -468,7 +468,7 @@ impl<K: HashKey, S: StateStore> JoinHashMap<K, S> {
         } else {
             let prefix = key.deserialize(&self.join_key_data_types)?;
             self.metrics.insert_cache_miss_count += 1;
-            // Refill cache when the join key exist in neither cache or storage.
+            // Refill cache when the join key exists in neither cache or storage.
             if !self.state.table.may_exist(&prefix).await? {
                 let mut state = JoinEntryState::default();
                 state.insert(pk, join_row.encode());