fix opaque type

Signed-off-by: xxchan <xxchan22f@gmail.com>
risingwavelabs · Jun 20, 2024 · 1906cb5 · 1906cb5
1 parent d2c306d
commit 1906cb5
Showing 1 changed file with 35 additions and 28 deletions.
diff --git a/src/storage/src/store_impl.rs b/src/storage/src/store_impl.rs
@@ -42,9 +42,41 @@ use crate::monitor::{
 use crate::opts::StorageOpts;
 use crate::StateStore;
 
-pub type HummockStorageType = impl StateStore + AsHummock;
-pub type MemoryStateStoreType = impl StateStore + AsHummock;
-pub type SledStateStoreType = impl StateStore + AsHummock;
+mod opaque_type {
+    use super::*;
+
+    pub type HummockStorageType = impl StateStore + AsHummock;
+    pub type MemoryStateStoreType = impl StateStore + AsHummock;
+    pub type SledStateStoreType = impl StateStore + AsHummock;
+
+    impl StateStoreImpl {
+        pub(super) fn in_memory(
+            state_store: MemoryStateStore,
+            storage_metrics: Arc<MonitoredStorageMetrics>,
+        ) -> Self {
+            // The specific type of MemoryStateStoreType in deducted here.
+            Self::MemoryStateStore(may_dynamic_dispatch(state_store).monitored(storage_metrics))
+        }
+
+        pub fn hummock(
+            state_store: HummockStorage,
+            storage_metrics: Arc<MonitoredStorageMetrics>,
+        ) -> Self {
+            // The specific type of HummockStateStoreType in deducted here.
+            Self::HummockStateStore(
+                may_dynamic_dispatch(may_verify(state_store)).monitored(storage_metrics),
+            )
+        }
+
+        pub fn sled(
+            state_store: SledStateStore,
+            storage_metrics: Arc<MonitoredStorageMetrics>,
+        ) -> Self {
+            Self::SledStateStore(may_dynamic_dispatch(state_store).monitored(storage_metrics))
+        }
+    }
+}
+pub use opaque_type::{HummockStorageType, MemoryStateStoreType, SledStateStoreType};
 
 /// The type erased [`StateStore`].
 #[derive(Clone, EnumAsInner)]
@@ -109,31 +141,6 @@ fn may_verify(state_store: impl StateStore + AsHummock) -> impl StateStore + AsH
 }
 
 impl StateStoreImpl {
-    fn in_memory(
-        state_store: MemoryStateStore,
-        storage_metrics: Arc<MonitoredStorageMetrics>,
-    ) -> Self {
-        // The specific type of MemoryStateStoreType in deducted here.
-        Self::MemoryStateStore(may_dynamic_dispatch(state_store).monitored(storage_metrics))
-    }
-
-    pub fn hummock(
-        state_store: HummockStorage,
-        storage_metrics: Arc<MonitoredStorageMetrics>,
-    ) -> Self {
-        // The specific type of HummockStateStoreType in deducted here.
-        Self::HummockStateStore(
-            may_dynamic_dispatch(may_verify(state_store)).monitored(storage_metrics),
-        )
-    }
-
-    pub fn sled(
-        state_store: SledStateStore,
-        storage_metrics: Arc<MonitoredStorageMetrics>,
-    ) -> Self {
-        Self::SledStateStore(may_dynamic_dispatch(state_store).monitored(storage_metrics))
-    }
-
     pub fn shared_in_memory_store(storage_metrics: Arc<MonitoredStorageMetrics>) -> Self {
         Self::in_memory(MemoryStateStore::shared(), storage_metrics)
     }