Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection: Add a tags to the CREATE CONNECTION command #10451

Closed
StrikeW opened this issue Jun 20, 2023 · 4 comments · Fixed by #10582
Closed

Connection: Add a tags to the CREATE CONNECTION command #10451

StrikeW opened this issue Jun 20, 2023 · 4 comments · Fixed by #10582
Assignees
Milestone

Comments

@StrikeW
Copy link
Contributor

StrikeW commented Jun 20, 2023

Add a tags field to the WITH clause of the CREATE CONNECTION.

@StrikeW StrikeW self-assigned this Jun 20, 2023
@github-actions github-actions bot added this to the release-0.20 milestone Jun 20, 2023
@neverchanje
Copy link
Contributor

What will this attribute be used for?

@StrikeW
Copy link
Contributor Author

StrikeW commented Jun 25, 2023

What will this attribute be used for?

Tag cloud resources for periodically check for if there is resource leakage.
https://docs.aws.amazon.com/tag-editor/latest/userguide/tagging.html

@neverchanje
Copy link
Contributor

A little bit weird. Why would the RisingWave have to be aware of the AWS tags when setting up the connection? Furthermore, is this config required or optional?

@StrikeW
Copy link
Contributor Author

StrikeW commented Jun 25, 2023

This should be an optional attribute for the connection. You can refer to the wg-privatelink for the context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants