Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(privatelink): add tags to the endpoint in CREATE CONNECTION command #10582

Merged
merged 8 commits into from Jun 27, 2023

Conversation

WillyKidd
Copy link
Contributor

@WillyKidd WillyKidd commented Jun 27, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

example usage:
in risingwave...
image
in aws endpoint panel..
image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

Documentation

  • My PR contains user-facing changes.

Types of user-facing changes

  • SQL commands, functions, and operators

Release note

Allow user to tag the created vpc endpoints when creating a privatelink connection using risingwave.

  • Using SQL: an optional tags property in the with clause in CREATE CONNECTION
  • Using environment variable RW_PRIVATELINK_ENDPOINT_DEFAULT_TAGS (considered to be default tags)

Both should have the syntax key1=val1,key2=val2...
If both methods are used, the tags specified in the environment variable will be appended to the ones specified in the with clause in SQL.

@WillyKidd WillyKidd requested a review from StrikeW June 27, 2023 05:52
@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Jun 27, 2023
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm. As discussed in the wg, add a optional environment variable on Meta as the default tag to add to each connection.

@StrikeW
Copy link
Contributor

StrikeW commented Jun 27, 2023

Rebase your branch to fix the CI and please add some release notes for the PR. @WillyKidd

@codecov
Copy link

codecov bot commented Jun 27, 2023

Codecov Report

Merging #10582 (c76f080) into main (29edca4) will decrease coverage by 0.03%.
The diff coverage is 1.49%.

@@            Coverage Diff             @@
##             main   #10582      +/-   ##
==========================================
- Coverage   70.26%   70.24%   -0.03%     
==========================================
  Files        1274     1274              
  Lines      219116   219182      +66     
==========================================
  Hits       153967   153967              
- Misses      65149    65215      +66     
Flag Coverage Δ
rust 70.24% <1.49%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/handler/create_connection.rs 0.00% <0.00%> (ø)
src/meta/src/lib.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/cloud_provider.rs 0.00% <0.00%> (ø)
src/meta/src/rpc/service/ddl_service.rs 0.00% <0.00%> (ø)
src/meta/src/manager/env.rs 70.13% <100.00%> (+0.20%) ⬆️

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest lgtm

src/meta/src/rpc/cloud_provider.rs Outdated Show resolved Hide resolved
@WillyKidd WillyKidd enabled auto-merge June 27, 2023 11:26
@WillyKidd WillyKidd added this pull request to the merge queue Jun 27, 2023
Merged via the queue into main with commit f3ed466 Jun 27, 2023
35 of 36 checks passed
@WillyKidd WillyKidd deleted the weili/privatelink-tag branch June 27, 2023 12:38
@StrikeW
Copy link
Contributor

StrikeW commented Jun 27, 2023

This pr is required from cloud team for GA. Do we need to pick it to 0.19-rc? @lmatz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection: Add a tags to the CREATE CONNECTION command
3 participants