New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(privatelink): add tags to the endpoint in CREATE CONNECTION command #10582
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest lgtm. As discussed in the wg, add a optional environment variable on Meta as the default tag to add to each connection.
Rebase your branch to fix the CI and please add some release notes for the PR. @WillyKidd |
Codecov Report
@@ Coverage Diff @@
## main #10582 +/- ##
==========================================
- Coverage 70.26% 70.24% -0.03%
==========================================
Files 1274 1274
Lines 219116 219182 +66
==========================================
Hits 153967 153967
- Misses 65149 65215 +66
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest lgtm
This pr is required from cloud team for GA. Do we need to pick it to 0.19-rc? @lmatz |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
create connection
for more convenient resource management for the cloud teamtags
parameter in the with clause increate connection
, with the format 'key1=val1,key2=val2...'example usage:
in risingwave...
in aws endpoint panel..
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Types of user-facing changes
Release note
Allow user to tag the created vpc endpoints when creating a privatelink connection using risingwave.
tags
property in thewith
clause inCREATE CONNECTION
RW_PRIVATELINK_ENDPOINT_DEFAULT_TAGS
(considered to be default tags)Both should have the syntax
key1=val1,key2=val2...
If both methods are used, the tags specified in the environment variable will be appended to the ones specified in the
with
clause in SQL.