Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the s3 source connector and rename s3_v2 to s3 #16234

Closed
neverchanje opened this issue Apr 10, 2024 · 1 comment · Fixed by #16337
Closed

Deprecate the s3 source connector and rename s3_v2 to s3 #16234

neverchanje opened this issue Apr 10, 2024 · 1 comment · Fixed by #16337
Assignees
Milestone

Comments

@neverchanje
Copy link
Contributor

In the upcoming v1.9, we should deprecate the old s3 connector. We can retain its code for backward compatibility in the short term, but renaming it to 's3_deprecate'. Additionally, we can remove its document to avoid misuse.

In the meanwhile, we should rename s3_v2 to s3, making it the default implementation.

@tabVersion
Copy link
Contributor

I agree with the purpose of deprecating legacy s3 connector but I don't think renaming it to an existing connector name is desirable. It may cause some trouble handing compatibility.
How about just refuse the requests for s3 connector and tell them use s3_v2 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants