Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate legacy s3 connector #16337

Merged
merged 5 commits into from
Apr 18, 2024
Merged

feat: deprecate legacy s3 connector #16337

merged 5 commits into from
Apr 18, 2024

Conversation

tabVersion
Copy link
Contributor

@tabVersion tabVersion commented Apr 16, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #16234

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Edited by @neverchanje
The only available s3 connector is now s3_v2. s3 is deprecated and should not appear in the document.

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just refuse the requests for s3 connector and tell them use s3_v2 instead.

A little bit weird but OK for the short-term.

@tabVersion
Copy link
Contributor Author

cc @BugenZhao as introducing new item in RwErrorCode

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think main-cron ci tests will fail. Perhaps you will want to remove them.

@tabVersion tabVersion added ci/run-main-cron user-facing-changes Contains changes that are visible to users labels Apr 18, 2024
@tabVersion
Copy link
Contributor Author

maid cron failed on an irrelevant hummock test, merging now
https://buildkite.com/risingwavelabs/main-cron/builds/2380

@tabVersion tabVersion added this pull request to the merge queue Apr 18, 2024
Merged via the queue into main with commit b73643a Apr 18, 2024
27 of 29 checks passed
@tabVersion tabVersion deleted the tab/deprecate-s3 branch April 18, 2024 10:55
tabVersion added a commit to risingwavelabs/risingwave-docs that referenced this pull request May 9, 2024
ShanlanLi added a commit to risingwavelabs/risingwave-docs that referenced this pull request May 13, 2024
* deprecate legacy s3 connector

ref risingwavelabs/risingwave#16337

* Update ingest-from-s3.md

* update 1.9 ver

---------

Co-authored-by: Shanlan(Lily) <150168166+ShanlanLi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate the s3 source connector and rename s3_v2 to s3
3 participants