Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking: import test cases from other DBs #5156

Open
4 tasks
lmatz opened this issue Sep 7, 2022 · 2 comments
Open
4 tasks

Tracking: import test cases from other DBs #5156

lmatz opened this issue Sep 7, 2022 · 2 comments
Assignees
Labels
component/test Test related issue. help wanted Issues that need help from contributors type/tracking Tracking issue.

Comments

@lmatz
Copy link
Contributor

lmatz commented Sep 7, 2022

PG: We want to be reasonably compatible with PG.
DuckDB: It is pretty popular and gaining more momentum nowadays and the test cases are pretty well categorized.
CRDB: It is also used by many other (streaming) DBs.
SQLite: It is a very rich source of test cases. Lots of other DBs use it. Long track record.

@lmatz lmatz added help wanted Issues that need help from contributors component/test Test related issue. labels Sep 7, 2022
@github-actions github-actions bot added this to the release-0.1.13 milestone Sep 7, 2022
@lmatz lmatz removed this from the release-0.1.13 milestone Sep 7, 2022
@lmatz lmatz added type/tracking Tracking issue. stage/Beta labels Oct 24, 2022
@lmatz lmatz added this to the release-0.1.14 milestone Oct 24, 2022
@lmatz lmatz self-assigned this Nov 23, 2022
@fuyufjh fuyufjh removed this from the release-0.1.15 milestone Dec 19, 2022
@lmatz
Copy link
Contributor Author

lmatz commented Apr 4, 2023

I agree that postgres contains too many features that we will never need

but the test cases from duckdb and sqllogictest seem relatively clean, i.e. a limited set of feature but test many combinations of them.

I suggest after reviewing duckdb, we proceed to sqllogictest next.

@xiangjinwu
Copy link
Contributor

xiangjinwu commented Apr 4, 2023

Also note that duckdb and sqlite is not PostgreSQL-compatible (e.g. #8830 (comment)), and may contain features not supported by PostgreSQL. It is not a goal to be able to pass their tests unmodified.

@xxchan xxchan removed the stage/Beta label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue. help wanted Issues that need help from contributors type/tracking Tracking issue.
Projects
None yet
Development

No branches or pull requests

4 participants