feat: support `date_part` function and more fields for `extract` #8830

wangrunji0408 · 2023-03-28T09:55:41Z

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

resolve #8817.

support date_part function
support extract and date_part from interval
support the following fields for extract and date_part:
- millisecond
- microsecond
- epoch
- millennium
- century
- decade
- isoyear
- quarter
- week
- isodow
- julian

Checklist For Contributors

I have written necessary rustdoc comments
I have added necessary unit tests and integration tests
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
I have demonstrated that backward compatibility is not broken by breaking changes and created issues to track deprecated features to be removed in the future. (Please refer to the issue)
All checks passed in ./risedev check (or alias, ./risedev c)

Checklist For Reviewers

I have requested macro/micro-benchmarks as this PR can affect performance substantially, and the results are shown.

Documentation

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

SQL commands, functions, and operators

Release note

support date_part function
support extract and date_part from interval
support the following fields for extract and date_part:
- millisecond
- microsecond
- epoch
- millennium
- century
- decade
- isoyear
- quarter
- week
- isodow
- Julian

BugenZhao · 2023-03-28T11:00:59Z

Maybe we should also update the date.out under expected directory?

xiangjinwu

btw this PR is not enough to resolve the linked issue. We are still lacking support to extract from the interval type.

src/frontend/src/binder/expr/function.rs

src/expr/src/vector_op/extract.rs

src/tests/regress/data/sql/date.sql

wangrunji0408 · 2023-03-28T14:04:57Z

The water here is deeper than I imaged. 🙃

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu · 2023-03-29T07:55:11Z

The water here is deeper than I imaged. 🙃

More notes ...

source must be a value expression of type timestamp, time, or interval. (Expressions of type date are cast to timestamp and can therefore be used as well.)

This description in PostgreSQL is misleading.

The truth is:

extract is implemented for date (prosrc)
date_part of date manually cast to timestamp rather than relying on automatic implicit cast rule, which would cast to timestamptz.

Signed-off-by: Runji Wang <wangrunji0408@163.com>

wangrunji0408 · 2023-03-29T10:04:00Z

🆘 Is there any instruction about how to extract(epoch from interval)? especially for year and month.

xiangjinwu · 2023-03-29T16:21:02Z

🆘 Is there any instruction about how to extract(epoch from interval)? especially for year and month.

Seems not well documented. But at least we have access to the source ...
https://github.com/postgres/postgres/blob/REL_15_2/src/backend/utils/adt/timestamp.c#L5304

Signed-off-by: Runji Wang <wangrunji0408@163.com>

src/common/src/types/interval.rs

Signed-off-by: Runji Wang <wangrunji0408@163.com>

src/expr/src/vector_op/extract.rs

src/common/src/array/arrow.rs

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu · 2023-03-30T09:52:01Z

For the regress test failure on extract(epoch from interval '34 years'), it is a difference between PostgreSQL 14 and 15. We are referencing the source of 15 but the expected file was generated by 14

postgres/postgres@f2a2bf6

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu · 2023-03-30T10:35:01Z

src/common/src/types/interval.rs

+
+    /// Returns the microseconds since 1970-01-01 00:00:00+00.
+    pub fn epoch_in_micros(&self) -> i128 {
+        // https://github.com/postgres/postgres/blob/REL_15_2/src/backend/utils/adt/timestamp.c#L5304


Just sharing a wired behavior of PostgreSQL. Not suggesting any actions...
https://www.db-fiddle.com/f/5LLhMM7MY2DpiQwNzxYMkV/0
Unequal intervals may return the same epoch, and equal intervals may return different epochs.

st1page · 2023-03-30T10:54:01Z

FYI: https://stackoverflow.com/questions/62196108/is-postgresqls-extractquarter-from-interval-1-based
But I still do not know why 🥵

Signed-off-by: Runji Wang <wangrunji0408@163.com>

CAJan93 · 2023-03-30T13:29:26Z

src/tests/regress/data/sql/date.sql

--@ SELECT EXTRACT(CENTURY FROM DATE '1901-01-01');    -- 20
--@ SELECT EXTRACT(CENTURY FROM DATE '2000-12-31');    -- 20
--@ SELECT EXTRACT(CENTURY FROM DATE '2001-01-01');    -- 21
+SELECT EXTRACT(CENTURY FROM DATE '1900-12-31');    -- 19


Learned something new today. I expected that 1900 is the 20th century :D

src/common/src/types/interval.rs

Signed-off-by: Runji Wang <wangrunji0408@163.com>

codecov · 2023-03-31T03:26:34Z

Codecov Report

Merging #8830 (5139182) into main (c617632) will increase coverage by 0.03%.
The diff coverage is 92.95%.

@@            Coverage Diff             @@
##             main    #8830      +/-   ##
==========================================
+ Coverage   70.72%   70.75%   +0.03%     
==========================================
  Files        1183     1183              
  Lines      195532   195729     +197     
==========================================
+ Hits       138281   138483     +202     
+ Misses      57251    57246       -5

Flag	Coverage Δ
rust	`70.75% <92.95%> (+0.03%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/expr/src/vector_op/arithmetic_op.rs	`68.87% <50.00%> (ø)`
src/expr/src/vector_op/extract.rs	`90.66% <91.37%> (+12.72%)`	⬆️
src/common/src/types/interval.rs	`81.06% <97.40%> (+1.02%)`	⬆️
src/common/src/array/arrow.rs	`63.71% <100.00%> (ø)`
src/common/src/array/interval_array.rs	`100.00% <100.00%> (ø)`
src/common/src/types/chrono_wrapper.rs	`64.00% <100.00%> (ø)`
src/common/src/util/value_encoding/mod.rs	`93.18% <100.00%> (ø)`
src/expr/src/vector_op/cast.rs	`89.57% <100.00%> (ø)`
src/expr/src/vector_op/tumble.rs	`82.67% <100.00%> (ø)`
src/frontend/src/binder/expr/function.rs	`89.33% <100.00%> (+0.01%)`	⬆️

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

xiangjinwu

Rest lgtm.

src/common/src/types/interval.rs

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu

🚀

src/common/src/types/interval.rs

Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>

commit ee6d44f Author: Clearlove <52417396+Eurekaaw@users.noreply.github.com> Date: Mon Apr 10 13:11:02 2023 -0400 feat(optimizer): push `LogicalLimit` down `LogicalProject`, enabled in batch (risingwavelabs#8971) Signed-off-by: Clearlove <yifei.c.wei@gmail.com> commit 5bb0911 Author: Bohan Zhang <tabvision@bupt.icu> Date: Mon Apr 10 23:01:53 2023 +0800 fix: timestamptz type mismatch (risingwavelabs#9090) Signed-off-by: tabVersion <tabvision@bupt.icu> commit ab09d29 Author: stonepage <40830455+st1page@users.noreply.github.com> Date: Mon Apr 10 21:54:15 2023 +0800 chore: improve error msg (risingwavelabs#9089) commit 7088fd3 Author: Richard Chien <stdrc@outlook.com> Date: Mon Apr 10 20:20:53 2023 +0800 refactor(common): remove `unwrap` from `memcmp_encoding` and improve `encode_row` (risingwavelabs#9087) Signed-off-by: Richard Chien <stdrc@outlook.com> commit 490161d Author: StrikeW <wangsiyuanse@gmail.com> Date: Mon Apr 10 18:56:27 2023 +0800 perf(storage): Merge multiple imms in the staging version to a large one (risingwavelabs#7368) commit fcc069a Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Mon Apr 10 18:43:13 2023 +0800 feat(meta cache): stats meta cache unhit in prometheus (risingwavelabs#9078) commit 4929b30 Author: Dylan <chenzl25@mail2.sysu.edu.cn> Date: Mon Apr 10 17:31:52 2023 +0800 feat(stream): stream window join naming (risingwavelabs#9076) commit fd38f3d Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Mon Apr 10 02:24:30 2023 -0700 fix(planner): `stddev`/`var` rewriter panic due to mix use of pre/post project index (risingwavelabs#9081) commit a3fc14a Author: Bugen Zhao <i@bugenzhao.com> Date: Mon Apr 10 16:08:45 2023 +0800 fix(expr): correctly handle unicode for substr (risingwavelabs#9079) Signed-off-by: Bugen Zhao <i@bugenzhao.com> commit d1868a9 Author: August <pin@singularity-data.com> Date: Mon Apr 10 15:56:52 2023 +0800 fix: reject ddl rather than panic when no available parallel units to schedule (risingwavelabs#9080) commit 046f1d2 Author: Dylan <chenzl25@mail2.sysu.edu.cn> Date: Mon Apr 10 15:08:50 2023 +0800 feat(optimizer): support functional index selection (risingwavelabs#9067) commit a63807d Author: Shanicky Chen <peng@singularity-data.com> Date: Mon Apr 10 14:45:43 2023 +0800 chore: remove Uint256 functionality and related code (risingwavelabs#9073) commit fc5836f Author: xxchan <xxchan22f@gmail.com> Date: Mon Apr 10 08:33:22 2023 +0200 ci: reuse some code across scripts (risingwavelabs#8926) commit 10190e8 Author: Dylan <chenzl25@mail2.sysu.edu.cn> Date: Mon Apr 10 13:48:31 2023 +0800 fix(stream): fix inner interval join (risingwavelabs#9071) commit ed5af28 Author: congyi wang <58715567+wcy-fdu@users.noreply.github.com> Date: Mon Apr 10 12:14:57 2023 +0800 feat(streaming): monitor materialize cache miss rate when handling pk conflict (risingwavelabs#8946) commit 1e3221b Author: Lanqing Yang <lanqingy@usc.edu> Date: Sun Apr 9 20:59:11 2023 -0700 feat(expr): support for sqrt function (risingwavelabs#9017) Co-authored-by: root <root@HQ-10MSTD3EY.roblox.local> commit 95ab15c Author: Renjie Liu <liurenjie2008@gmail.com> Date: Sun Apr 9 17:30:45 2023 +0800 feat: Estimate size for data chunk (risingwavelabs#9050) commit ced72de Author: Dylan <chenzl25@mail2.sysu.edu.cn> Date: Sun Apr 9 16:34:23 2023 +0800 feat(frontend): support functional indexes creation (risingwavelabs#8976) commit d8926b8 Author: William Wen <44139337+wenym1@users.noreply.github.com> Date: Sun Apr 9 01:47:25 2023 +0200 feat(sink): introduce log trait and adopt log reader and write in sink executor (risingwavelabs#8558) commit cc93b46 Author: Yuanxin Cao <60498509+xx01cyx@users.noreply.github.com> Date: Sat Apr 8 23:50:16 2023 +0800 fix(sink): allow parsing `bool` and `u32` for kafka sink config (risingwavelabs#9057) commit de6c5a3 Author: Bugen Zhao <i@bugenzhao.com> Date: Fri Apr 7 23:19:15 2023 +0800 refactor(common): do not leak types on row (risingwavelabs#9053) Signed-off-by: Bugen Zhao <i@bugenzhao.com> commit 1aa1278 Author: Tesla Zhang‮ <ice1000kotlin@foxmail.com> Date: Fri Apr 7 11:00:32 2023 -0400 refactor(plan_node): create `BatchPlanRef`, simplify `HopWindow` nodes (risingwavelabs#9044) commit c343f00 Author: congyi wang <58715567+wcy-fdu@users.noreply.github.com> Date: Fri Apr 7 22:19:21 2023 +0800 refactor(metrics): fix cache metrics to be table id + actor id (risingwavelabs#9039) commit 9a15a88 Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Fri Apr 7 03:19:50 2023 -0700 chore: `rust_decimal` feature -db-tokio-postgres +maths (risingwavelabs#9043) commit 85980fd Author: Renjie Liu <liurenjie2008@gmail.com> Date: Fri Apr 7 16:55:24 2023 +0800 feat: Implement GetSize for array (risingwavelabs#8995) commit 36dd239 Author: Bugen Zhao <i@bugenzhao.com> Date: Fri Apr 7 15:20:21 2023 +0800 refactor: do not leak the nested runtime (risingwavelabs#8968) Signed-off-by: Bugen Zhao <i@bugenzhao.com> Signed-off-by: Runji Wang <wangrunji0408@163.com> Co-authored-by: Runji Wang <wangrunji0408@163.com> commit e685bdb Author: Bohan Zhang <tabvision@bupt.icu> Date: Fri Apr 7 14:18:06 2023 +0800 chore: deprecate console sink (risingwavelabs#8950) Signed-off-by: tabVersion <tabvision@bupt.icu> commit 5169ce9 Author: Richard Chien <stdrc@outlook.com> Date: Fri Apr 7 14:14:17 2023 +0800 feat(stream common): add internal cache for `SortBuffer` (risingwavelabs#8963) Signed-off-by: Richard Chien <stdrc@outlook.com> commit 09e6a63 Author: ZENOTME <43447882+ZENOTME@users.noreply.github.com> Date: Fri Apr 7 14:08:15 2023 +0800 refactor(frontend): refactor query to reduce redundent code in extended mode (risingwavelabs#9023) commit 8e0bf7a Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Thu Apr 6 10:11:45 2023 -0700 fix(sqlparser): support more PostgreSQL `trim` syntax (risingwavelabs#8985) commit 8038315 Author: Xinjing Hu <honeta@qq.com> Date: Thu Apr 6 20:59:17 2023 +0800 perf(encoding): add benchmark for data chunk encoding (risingwavelabs#9035) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 5af13c1 Author: Zhanxiang (Patrick) Huang <hzxa21@hotmail.com> Date: Thu Apr 6 20:34:58 2023 +0800 feat(metric): introduce an alert panel in grafana user dashboard (risingwavelabs#9031) commit 3af7d21 Author: Noel Kwan <47273164+kwannoel@users.noreply.github.com> Date: Thu Apr 6 20:14:34 2023 +0800 feat(sqlsmith): Generate more join expressions (risingwavelabs#8395) commit 1293fda Author: xxchan <xxchan22f@gmail.com> Date: Thu Apr 6 13:40:34 2023 +0200 ci: increase timeout for e2e java-binding test (risingwavelabs#9032) commit eb20393 Author: Noel Kwan <47273164+kwannoel@users.noreply.github.com> Date: Thu Apr 6 18:36:28 2023 +0800 perf(common): Optimize null_bitmap with `Set64` (risingwavelabs#8941) Co-authored-by: Bugen Zhao <i@bugenzhao.com> commit 29389e1 Author: Shanicky Chen <peng@singularity-data.com> Date: Thu Apr 6 18:07:42 2023 +0800 feat(common): introduce ArrayBuilder and Array for Int256/Uint256 (risingwavelabs#8989) Co-authored-by: lmatz <lmatz823@gmail.com> commit 83b7c79 Author: Bohan Zhang <tabvision@bupt.icu> Date: Thu Apr 6 17:52:55 2023 +0800 feat(metrics): add metric for source upstream (risingwavelabs#9027) Signed-off-by: tabVersion <tabvision@bupt.icu> commit 78505b1 Author: Runji Wang <wangrunji0408@163.com> Date: Thu Apr 6 17:40:40 2023 +0800 fix(udf): fix missing chunks (risingwavelabs#9025) Signed-off-by: Runji Wang <wangrunji0408@163.com> Co-authored-by: lmatz <lmatz823@gmail.com> commit ba2f6e1 Author: Zhanxiang (Patrick) Huang <hzxa21@hotmail.com> Date: Thu Apr 6 16:17:57 2023 +0800 feat(metric): add recovery metrics (risingwavelabs#9022) commit ea53cf3 Author: Runji Wang <wangrunji0408@163.com> Date: Thu Apr 6 15:23:51 2023 +0800 test: simulate for worker node heartbeat timeout (risingwavelabs#7640) Signed-off-by: Runji Wang <wangrunji0408@163.com> Co-authored-by: August <pin@singularity-data.com> Co-authored-by: Shanicky Chen <peng@singularity-data.com> Co-authored-by: Shanicky Chen <peng@risingwave-labs.com> commit b19e651 Author: Bohan Zhang <tabvision@bupt.icu> Date: Thu Apr 6 14:58:51 2023 +0800 fix: ban types when creating sink (risingwavelabs#9008) Signed-off-by: tabVersion <tabvision@bupt.icu> commit 4c0a0b4 Author: August <pin@singularity-data.com> Date: Thu Apr 6 14:42:52 2023 +0800 fix: fix some check and clean for drop database and schema (risingwavelabs#8981) commit 8f8c191 Author: Richard Chien <stdrc@outlook.com> Date: Thu Apr 6 14:28:01 2023 +0800 refactor(stream sort): use new `SortBuffer` in `SortExecutor` (risingwavelabs#8891) Signed-off-by: Richard Chien <stdrc@outlook.com> commit efe56ec Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Thu Apr 6 14:17:47 2023 +0800 fix(expr): align `position` syntax and `strpos` semantic with SQL standard (risingwavelabs#9000) commit f1b7942 Author: WillyKidd <57129289+WillyKidd@users.noreply.github.com> Date: Thu Apr 6 13:39:31 2023 +0800 feat(source): introduce create/show connection statement (risingwavelabs#8907) commit 7c9da96 Author: Tesla Zhang‮ <ice1000kotlin@foxmail.com> Date: Thu Apr 6 01:24:48 2023 -0400 refactor(plan_node): `TopN` simplification (risingwavelabs#9011) commit f80ef5d Author: Noel Kwan <47273164+kwannoel@users.noreply.github.com> Date: Thu Apr 6 12:26:26 2023 +0800 bench(common): add more benchmark cases for unaligned number of keys (risingwavelabs#9018) commit 3091f16 Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Thu Apr 6 08:07:44 2023 +0800 perf(hash join): do not store null rows (close risingwavelabs#9009) (risingwavelabs#9010) commit 110972a Author: lmatz <lmatz823@gmail.com> Date: Wed Apr 5 15:56:11 2023 +0800 fix(binder): multiple unions should retain the same cte_to_relation context (risingwavelabs#9007) commit be4f748 Author: Eric Fu <eric@singularity-data.com> Date: Wed Apr 5 15:31:30 2023 +0800 fix(risedev): auto build connector node (risingwavelabs#9006) commit b67e00f Author: broccoliSpicy <93440049+broccoliSpicy@users.noreply.github.com> Date: Wed Apr 5 14:21:33 2023 +0800 fix(binder): Incorrect cast when specifying columns (risingwavelabs#8770) Co-authored-by: xxchan <xxchan22f@gmail.com> commit ce25cf5 Author: Runji Wang <wangrunji0408@163.com> Date: Wed Apr 5 14:20:55 2023 +0800 fix(udf): fix wrong number of rows (risingwavelabs#9003) Signed-off-by: Runji Wang <wangrunji0408@163.com> commit db072cb Author: ZENOTME <43447882+ZENOTME@users.noreply.github.com> Date: Wed Apr 5 10:32:55 2023 +0800 feat(frontend):support pull_up_hop rule (risingwavelabs#8954) commit 731f211 Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Tue Apr 4 23:46:40 2023 +0800 feat(binder): support some alternate names for existing exprs (risingwavelabs#8998) commit 29c4185 Author: ZENOTME <43447882+ZENOTME@users.noreply.github.com> Date: Tue Apr 4 22:54:51 2023 +0800 refactor(frontend): refine extended handle (risingwavelabs#8992) commit 381e3b8 Author: Zhanxiang (Patrick) Huang <hzxa21@hotmail.com> Date: Tue Apr 4 22:35:27 2023 +0800 feat(grafana): introduce a new dashboard to dsiplay user facing metrics (risingwavelabs#8994) commit ef22c5b Author: Bohan Zhang <tabvision@bupt.icu> Date: Tue Apr 4 20:52:54 2023 +0800 chore: add metrics for native chunk (risingwavelabs#8997) Signed-off-by: tabVersion <tabvision@bupt.icu> commit fadd752 Author: Noel Kwan <47273164+kwannoel@users.noreply.github.com> Date: Tue Apr 4 20:39:02 2023 +0800 chore(common): add more benchmark cases for hash key (risingwavelabs#8993) commit 5d8c0b4 Author: Tao Wu <wutao@singularity-data.com> Date: Tue Apr 4 19:59:09 2023 +0800 test: add e2e tests for natural join and cross join (risingwavelabs#8948) commit 35f7c0c Author: Shanicky Chen <peng@singularity-data.com> Date: Tue Apr 4 19:03:55 2023 +0800 feat(common): introduce Int256/Uint256 as Scalar and ScalarRef (risingwavelabs#8984) commit 085dc31 Author: xxchan <xxchan22f@gmail.com> Date: Tue Apr 4 12:22:50 2023 +0200 ci: reduce java-binding log (risingwavelabs#8967) commit 506986f Author: Yuhao Su <31772373+yuhao-su@users.noreply.github.com> Date: Tue Apr 4 18:09:28 2023 +0800 fix: drop table with watermark panic (risingwavelabs#8990) commit b9ff193 Author: Runji Wang <wangrunji0408@163.com> Date: Tue Apr 4 17:57:58 2023 +0800 fix(udf): fix decimal and list types for UDF (risingwavelabs#8958) Signed-off-by: Runji Wang <wangrunji0408@163.com> commit 80c477f Author: Bugen Zhao <i@bugenzhao.com> Date: Tue Apr 4 17:20:20 2023 +0800 feat(frontend): support update column to default value (risingwavelabs#8987) Signed-off-by: Bugen Zhao <i@bugenzhao.com> commit 570a253 Author: August <pin@singularity-data.com> Date: Tue Apr 4 15:54:45 2023 +0800 chore: notify function separately rather than inside the relation group (risingwavelabs#8983) commit ffc634f Author: xxchan <xxchan22f@gmail.com> Date: Tue Apr 4 09:49:10 2023 +0200 fix: fix cargo audit issues and add audit to ci (risingwavelabs#8959) commit bbe15be Author: Runji Wang <wangrunji0408@163.com> Date: Tue Apr 4 15:36:43 2023 +0800 feat: support `date_part` function and more fields for `extract` (risingwavelabs#8830) Signed-off-by: Runji Wang <wangrunji0408@163.com> Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> commit dca4ced Author: zwang28 <70626450+zwang28@users.noreply.github.com> Date: Tue Apr 4 15:24:43 2023 +0800 feat(metric): add metric for object size and count (risingwavelabs#8980) commit c617632 Author: Huangjw <1223644280@qq.com> Date: Tue Apr 4 14:47:56 2023 +0800 fix(ci): fix docker release scripts (risingwavelabs#8977) commit da1822c Author: Renjie Liu <liurenjie2008@gmail.com> Date: Tue Apr 4 14:01:32 2023 +0800 refactor: Remove unused code (risingwavelabs#8974) commit 9b53293 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Apr 4 13:31:14 2023 +0800 chore(deps): bump spin from 0.9.6 to 0.9.8 (risingwavelabs#8969) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 6687739 Author: Runji Wang <wangrunji0408@163.com> Date: Tue Apr 4 12:40:34 2023 +0800 fix(expr): fix `lpad` and `rpad` on empty fill string (risingwavelabs#8970) Signed-off-by: Runji Wang <wangrunji0408@163.com> commit 368ed93 Author: Bugen Zhao <i@bugenzhao.com> Date: Tue Apr 4 12:38:23 2023 +0800 fix(test): clean-up temporary config file (risingwavelabs#8972) Signed-off-by: Bugen Zhao <i@bugenzhao.com> commit 43bd8c9 Author: August <pin@singularity-data.com> Date: Tue Apr 4 12:14:10 2023 +0800 fix: use original lru crate in meta client and simulation (risingwavelabs#8956) commit 30dca71 Author: Tesla Zhang‮ <ice1000kotlin@foxmail.com> Date: Mon Apr 3 10:36:46 2023 -0400 refactor(plan_node): simplify `Expand` and `Filter` (risingwavelabs#8932) commit 626ff72 Author: xxchan <xxchan22f@gmail.com> Date: Mon Apr 3 15:28:41 2023 +0200 refactor(risedev): replace std::fs with fs_err (risingwavelabs#8955) commit 88d84a0 Author: Renjie Liu <liurenjie2008@gmail.com> Date: Mon Apr 3 18:51:10 2023 +0800 refactor: Add backtrace for risedev (risingwavelabs#8960) commit 1527b6c Author: Huangjw <1223644280@qq.com> Date: Mon Apr 3 18:45:16 2023 +0800 chore(release): update release version and fix ci release script (risingwavelabs#8913) commit 8278061 Author: ZENOTME <43447882+ZENOTME@users.noreply.github.com> Date: Mon Apr 3 16:30:10 2023 +0800 refactor(frontend): refactor extended query mode (risingwavelabs#8919) commit 06025d5 Author: lmatz <lmatz823@gmail.com> Date: Mon Apr 3 16:06:38 2023 +0800 chore(metrics): add and correct some description of metrics shown on Grafana (risingwavelabs#8890) commit 806c623 Author: Yuanxin Cao <60498509+xx01cyx@users.noreply.github.com> Date: Mon Apr 3 15:49:08 2023 +0800 feat(sink): reject invalid options when creating sink (risingwavelabs#8757) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 36c4605 Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Mon Apr 3 15:47:16 2023 +0800 test(regress): enable `strings` (risingwavelabs#8952) commit 3c884e1 Author: idx0-dev <124041366+idx0-dev@users.noreply.github.com> Date: Mon Apr 3 15:27:06 2023 +0800 feat: encode JSON in the same way as debezium (risingwavelabs#8865) commit 312d418 Author: Bohan Zhang <tabvision@bupt.icu> Date: Mon Apr 3 15:04:38 2023 +0800 fix: unstable test by checking cardinality instead of actual values (risingwavelabs#8947) Signed-off-by: tabVersion <tabvision@bupt.icu> commit 6c3c80d Author: Yuanxin Cao <60498509+xx01cyx@users.noreply.github.com> Date: Mon Apr 3 14:35:31 2023 +0800 feat(streaming): introduce dedup cache and append-only dedup executor (risingwavelabs#8874) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> commit 37ce407 Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Mon Apr 3 14:16:59 2023 +0800 fix(delete range): maintain unused iters in `seek` (close risingwavelabs#8928) (risingwavelabs#8929) commit 6f46e4c Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Mon Apr 3 14:14:18 2023 +0800 fix(shared buffer): shared buffer consistency issue (close risingwavelabs#8944) (risingwavelabs#8945) commit 4254b42 Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Mon Apr 3 13:48:38 2023 +0800 test(regress): enable `text` (risingwavelabs#8943) commit 7c259eb Author: WillyKidd <57129289+WillyKidd@users.noreply.github.com> Date: Mon Apr 3 13:42:10 2023 +0800 fix(connector): dbz source handler avoid oom more elegantly (risingwavelabs#8799) commit ea52212 Author: idx0-dev <124041366+idx0-dev@users.noreply.github.com> Date: Mon Apr 3 12:57:08 2023 +0800 feat(e2esinktest): switch to stream_chunk (risingwavelabs#8914) commit ac104a7 Author: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com> Date: Mon Apr 3 10:13:17 2023 +0800 test(regress): enable `case` (also covers `coalesce` `nullif`) (risingwavelabs#8921) commit 9f56e80 Author: StrikeW <wangsiyuanse@gmail.com> Date: Sun Apr 2 23:54:44 2023 +0800 fix(ci): quick fix for main cron ci (risingwavelabs#8931) commit e217689 Author: Tesla Zhang‮ <ice1000kotlin@foxmail.com> Date: Sun Apr 2 09:20:10 2023 -0400 refactor(plan_node): simplify agg-related nodes (risingwavelabs#8930) commit 039d4a0 Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Sat Apr 1 17:31:50 2023 +0800 fix(move table): apply version correctly (close risingwavelabs#8764) (risingwavelabs#8765) commit ad53077 Author: Shuxian Wang <wsx@berkeley.edu> Date: Fri Mar 31 15:21:13 2023 -0700 fix(stream): Better cache handling for temporal join. (risingwavelabs#8871) commit d687d71 Author: Bugen Zhao <i@bugenzhao.com> Date: Fri Mar 31 23:00:45 2023 +0800 refactor(config): split streaming and batch developer config (risingwavelabs#8911) Signed-off-by: Bugen Zhao <i@bugenzhao.com> commit ff1440f Author: Renjie Liu <liurenjie2008@gmail.com> Date: Fri Mar 31 21:39:27 2023 +0800 refactor: Remove unnecessary bash scripts (risingwavelabs#8925) commit dbbd1cb Author: Yuhao Su <31772373+yuhao-su@users.noreply.github.com> Date: Fri Mar 31 18:46:55 2023 +0800 feat(generated_columns): support select generated columns from source (risingwavelabs#8841) Co-authored-by: Bugen Zhao <i@bugenzhao.com> Co-authored-by: stonepage <40830455+st1page@users.noreply.github.com> commit e51b240 Author: Bohan Zhang <tabvision@bupt.icu> Date: Fri Mar 31 17:45:44 2023 +0800 fix: propagate connector reader error to the upper layer (risingwavelabs#8920) Signed-off-by: tabVersion <tabvision@bupt.icu> commit 74b935e Author: Noel Kwan <47273164+kwannoel@users.noreply.github.com> Date: Fri Mar 31 17:25:54 2023 +0800 docs: add metrics doc on barrier (risingwavelabs#8902) commit 96d92ca Author: Liang <44948473+soundOfDestiny@users.noreply.github.com> Date: Fri Mar 31 17:22:52 2023 +0800 feat(sst meta): rollback fetch meta strategy (risingwavelabs#8917) commit 6c99e93 Author: Li0k <yuli@singularity-data.com> Date: Fri Mar 31 16:45:39 2023 +0800 chore(storage): monitor compacting task count per level (risingwavelabs#8681) commit 188846e Author: Renjie Liu <liurenjie2008@gmail.com> Date: Fri Mar 31 16:29:42 2023 +0800 fix: Disable generated warning in docker compose (risingwavelabs#8916) commit 85ecc73 Author: August <pin@singularity-data.com> Date: Fri Mar 31 15:45:56 2023 +0800 fix: replay functions in snapshot on frontend (risingwavelabs#8912) commit dc5d3de Author: Kevin Axel <kevinaxel@163.com> Date: Fri Mar 31 15:42:03 2023 +0800 feat(optimizer): bushy join equivalent condition derivation (risingwavelabs#8668) Signed-off-by: Kevin Axel <kevinaxel@163.com> commit 010bec6 Author: Xinjing Hu <honeta@qq.com> Date: Fri Mar 31 15:32:24 2023 +0800 perf(encoding): use estimate size to reserve memory in row encoding (risingwavelabs#8909) Co-authored-by: stonepage <40830455+st1page@users.noreply.github.com> commit 1b05700 Author: Renjie Liu <liurenjie2008@gmail.com> Date: Fri Mar 31 15:10:23 2023 +0800 refactor: Simplify some commands in kafka cdc example. (risingwavelabs#8910) commit 9bcfb17 Author: Tesla Zhang‮ <ice1000kotlin@foxmail.com> Date: Fri Mar 31 02:20:44 2023 -0400 refactor(plan_node): Further simplify join-related plan nodes (risingwavelabs#8905) Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>

wangrunji0408 requested review from xiangjinwu and BugenZhao March 28, 2023 09:55

github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Mar 28, 2023

xiangjinwu reviewed Mar 28, 2023

View reviewed changes

src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved

src/expr/src/vector_op/extract.rs Outdated Show resolved Hide resolved

src/expr/src/vector_op/extract.rs Outdated Show resolved Hide resolved

src/tests/regress/data/sql/date.sql Outdated Show resolved Hide resolved

wangrunji0408 added 4 commits March 29, 2023 11:04

support date_part function

96eebc6

Signed-off-by: Runji Wang <wangrunji0408@163.com>

support more units for extract

ce52a64

Signed-off-by: Runji Wang <wangrunji0408@163.com>

fix date_part. merge extract_date and extract_time

3db6b7b

Signed-off-by: Runji Wang <wangrunji0408@163.com>

support julian

c7e435b

Signed-off-by: Runji Wang <wangrunji0408@163.com>

wangrunji0408 force-pushed the wrj/date-part branch from 795a19f to c7e435b Compare March 29, 2023 06:32

wangrunji0408 added 4 commits March 29, 2023 16:41

recover extract from date/time

47b36a0

Signed-off-by: Runji Wang <wangrunji0408@163.com>

implement extract/date_part from interval

8264024

Signed-off-by: Runji Wang <wangrunji0408@163.com>

enable test for extract from interval

91d55e2

Signed-off-by: Runji Wang <wangrunji0408@163.com>

to lowercase

75ee82c

Signed-off-by: Runji Wang <wangrunji0408@163.com>

support extract epoch from interval

24dafe0

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu reviewed Mar 30, 2023

View reviewed changes

src/common/src/types/interval.rs Outdated Show resolved Hide resolved

fix for negative interval

d609da0

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu reviewed Mar 30, 2023

View reviewed changes

src/expr/src/vector_op/extract.rs Outdated Show resolved Hide resolved

xiangjinwu reviewed Mar 30, 2023

View reviewed changes

src/common/src/array/arrow.rs Outdated Show resolved Hide resolved

wangrunji0408 added 2 commits March 30, 2023 16:55

fix decimal scale

494a137

Signed-off-by: Runji Wang <wangrunji0408@163.com>

fix test

f948c95

Signed-off-by: Runji Wang <wangrunji0408@163.com>

wangrunji0408 force-pushed the wrj/date-part branch from 8e70256 to f948c95 Compare March 30, 2023 09:18

rename functions of interval

c101256

Signed-off-by: Runji Wang <wangrunji0408@163.com>

fix interval overflow

66e166f

Signed-off-by: Runji Wang <wangrunji0408@163.com>

support extract epoch from time

74b3c5e

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu reviewed Mar 30, 2023

View reviewed changes

wangrunji0408 added 2 commits March 30, 2023 20:04

fix extract quarter from interval

609cf85

Signed-off-by: Runji Wang <wangrunji0408@163.com>

add more doctests

7a95d76

Signed-off-by: Runji Wang <wangrunji0408@163.com>

CAJan93 reviewed Mar 30, 2023

View reviewed changes

wangrunji0408 commented Mar 30, 2023

View reviewed changes

src/common/src/types/interval.rs Show resolved Hide resolved

wangrunji0408 added 2 commits March 30, 2023 22:48

fix clippy

8c5e66d

Signed-off-by: Runji Wang <wangrunji0408@163.com>

fix parse interval

bd1a21a

Signed-off-by: Runji Wang <wangrunji0408@163.com>

wangrunji0408 requested a review from xiangjinwu March 31, 2023 03:38

xiangjinwu reviewed Mar 31, 2023

View reviewed changes

src/common/src/types/interval.rs Outdated Show resolved Hide resolved

src/common/src/types/interval.rs Outdated Show resolved Hide resolved

src/common/src/types/interval.rs Outdated Show resolved Hide resolved

fix comments

5244a1d

Signed-off-by: Runji Wang <wangrunji0408@163.com>

xiangjinwu approved these changes Apr 4, 2023

View reviewed changes

src/common/src/types/interval.rs Outdated Show resolved Hide resolved

Update src/common/src/types/interval.rs

431a423

Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>

wangrunji0408 enabled auto-merge April 4, 2023 06:03

wangrunji0408 added this pull request to the merge queue Apr 4, 2023

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 4, 2023

Merge branch 'main' into wrj/date-part

5139182

wangrunji0408 added this pull request to the merge queue Apr 4, 2023

Merged via the queue into main with commit bbe15be Apr 4, 2023
33 checks passed

wangrunji0408 deleted the wrj/date-part branch April 4, 2023 08:02

xiangjinwu mentioned this pull request Apr 4, 2023

Tracking: import test cases from other DBs #5156

Open

4 tasks

This was referenced Apr 18, 2023

Document the date_part() function risingwavelabs/risingwave-docs#764

Closed

Document the added fields of extract () risingwavelabs/risingwave-docs#765

Closed

CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Apr 18, 2023

This was referenced Apr 27, 2023

Add fields to extract() function risingwavelabs/risingwave-docs#822

Merged

Add date_part() function risingwavelabs/risingwave-docs#832

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: support `date_part` function and more fields for `extract` #8830

feat: support `date_part` function and more fields for `extract` #8830

wangrunji0408 commented Mar 28, 2023 •

edited

BugenZhao commented Mar 28, 2023

xiangjinwu left a comment

wangrunji0408 commented Mar 28, 2023

xiangjinwu commented Mar 29, 2023

wangrunji0408 commented Mar 29, 2023 •

edited

xiangjinwu commented Mar 29, 2023

xiangjinwu commented Mar 30, 2023

xiangjinwu Mar 30, 2023 •

edited

st1page commented Mar 30, 2023

CAJan93 Mar 30, 2023

codecov bot commented Mar 31, 2023 •

edited

xiangjinwu left a comment

xiangjinwu left a comment

feat: support date_part function and more fields for extract #8830

feat: support date_part function and more fields for extract #8830

Conversation

wangrunji0408 commented Mar 28, 2023 • edited

What's changed and what's your intention?

Checklist For Contributors

Checklist For Reviewers

Documentation

Types of user-facing changes

Release note

BugenZhao commented Mar 28, 2023

xiangjinwu left a comment

Choose a reason for hiding this comment

wangrunji0408 commented Mar 28, 2023

xiangjinwu commented Mar 29, 2023

wangrunji0408 commented Mar 29, 2023 • edited

xiangjinwu commented Mar 29, 2023

xiangjinwu commented Mar 30, 2023

xiangjinwu Mar 30, 2023 • edited

Choose a reason for hiding this comment

st1page commented Mar 30, 2023

CAJan93 Mar 30, 2023

Choose a reason for hiding this comment

codecov bot commented Mar 31, 2023 • edited

Codecov Report

xiangjinwu left a comment

Choose a reason for hiding this comment

xiangjinwu left a comment

Choose a reason for hiding this comment

feat: support `date_part` function and more fields for `extract` #8830

feat: support `date_part` function and more fields for `extract` #8830

wangrunji0408 commented Mar 28, 2023 •

edited

wangrunji0408 commented Mar 29, 2023 •

edited

xiangjinwu Mar 30, 2023 •

edited

codecov bot commented Mar 31, 2023 •

edited