Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement replacing table plan in meta service. #7908

Closed
Tracked by #6903
BugenZhao opened this issue Feb 14, 2023 · 0 comments · Fixed by #8063
Closed
Tracked by #6903

Implement replacing table plan in meta service. #7908

BugenZhao opened this issue Feb 14, 2023 · 0 comments · Fixed by #8063
Milestone

Comments

@BugenZhao
Copy link
Member

No description provided.

@github-actions github-actions bot added this to the release-0.1.18 milestone Feb 14, 2023
mergify bot pushed a commit that referenced this issue Feb 16, 2023
This PR extends the new actor graph builder introduced in #7659 for replacing table plan, and adds the procedure of preparing the `TableFragments`. Note that the RPC with the compute nodes is not implemented so this is not utilized by the frontend yet.

Building an actor graph for schema change can be similar and symmetric to the MV on MV.
- For MV on MV, we have existing upstream `Materialize` fragments that give the requirements to the distribution of current `Chain`. We'll generate new dispatchers for the upstream `Materialize` in the result.
- For replacing table plan for schema change, we (may) have existing downstream `Chain` fragments that give the requirements to the distribution of current `Materialize`. We'll generate updates for the merger for the downstream `Chain` in the result.

Related:
- #7908

Approved-By: chenzl25
Approved-By: yezizp2012
mergify bot pushed a commit that referenced this issue Feb 21, 2023
The hanging channel is a channel that's external for a table fragments subgraph. We introduced this for MV on MV long ago, but after #4045 and #6170, this becomes not that necessary: we can simply create a pair of channels if not found in the `ChannelPool`.

https://github.com/risingwavelabs/risingwave/blob/b1891423a68b98dff39d7220a891cdea8bd67951/src/stream/src/task/mod.rs#L123-L138

This is a preparation step for #7908.

Approved-By: yezizp2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant