Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainability: too many type XxxKey = Vec<u8> as memcomparable encoded row type #8606

Closed
stdrc opened this issue Mar 16, 2023 · 0 comments · Fixed by #10319
Closed

maintainability: too many type XxxKey = Vec<u8> as memcomparable encoded row type #8606

stdrc opened this issue Mar 16, 2023 · 0 comments · Fixed by #10319
Assignees
@stdrc
Labels
type/refactor
Milestone
release-1.0

Comments

@stdrc
Copy link
Contributor

stdrc commented Mar 16, 2023

IMO we should return MemcmpEncoded(Box<[u8]>) in encode_value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stdrc stdrc

Labels
type/refactor
Projects
None yet
Milestone
release-1.0
2 participants
@stdrc @TennyZhuang