Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add system function user, current_user and current_role #10366

Merged
merged 3 commits into from
Jun 19, 2023

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jun 16, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#10134 , this PR implements system function user. Another bug found in #10367 .

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • SQL commands, functions, and operators

Release note

Implements system function user, current_user and current_role.

dev=> select user;
 user
------
 root
(1 row)

@github-actions github-actions bot added type/feature user-facing-changes Contains changes that are visible to users labels Jun 16, 2023
src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #10366 (e3cbe0c) into main (558cef5) will increase coverage by 0.00%.
The diff coverage is 90.32%.

@@           Coverage Diff           @@
##             main   #10366   +/-   ##
=======================================
  Coverage   70.52%   70.52%           
=======================================
  Files        1255     1255           
  Lines      213963   213988   +25     
=======================================
+ Hits       150891   150913   +22     
- Misses      63072    63075    +3     
Flag Coverage Δ
rust 70.52% <90.32%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/binder/expr/function.rs 87.55% <90.00%> (+0.01%) ⬆️
src/frontend/src/binder/expr/mod.rs 78.33% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@yezizp2012 yezizp2012 changed the title feat: add system function user feat: add system function user, current_user and current_role Jun 19, 2023
@yezizp2012 yezizp2012 added this pull request to the merge queue Jun 19, 2023
Merged via the queue into main with commit eeb2a01 Jun 19, 2023
36 of 37 checks passed
@yezizp2012 yezizp2012 deleted the zp/add-user branch June 19, 2023 08:14
lmatz pushed a commit that referenced this pull request Jun 19, 2023
@CharlieSYH CharlieSYH added the 📖✓ Covered or will be covered in the user docs. label Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants