-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(types): introduce Timestamptz
type
#10477
Conversation
4a6d04f
to
c41406d
Compare
c41406d
to
607a988
Compare
May I ask whether we're going to unify logical types ( Seems still impossible since there could some metadata in |
Exactly. Even though we have a 1-1 mapping between the variants of |
One example is |
Oh sorry the build failure is due to an uncaught conflict with #10462. Should be an easy fix. I am reviewing the other parts |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest lgtm. Thank you!
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Signed-off-by: Runji Wang <wangrunji0408@163.com>
Codecov Report
@@ Coverage Diff @@
## main #10477 +/- ##
==========================================
- Coverage 70.16% 70.15% -0.01%
==========================================
Files 1295 1296 +1
Lines 221572 221690 +118
==========================================
+ Hits 155455 155527 +72
- Misses 66117 66163 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Runji Wang <wangrunji0408@163.com>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR introduces
Timestamptz
type and array. It's another attempt after #7084.Checklist
I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934)../risedev check
(or alias,./risedev c
)Documentation