Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): monitor materialized view remote IO bytes #11054

Merged
merged 29 commits into from Aug 14, 2023
Merged

Conversation

wcy-fdu
Copy link
Contributor

@wcy-fdu wcy-fdu commented Jul 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

finish #10693

add this panel
read size

image

write size

image

Checklist

- [ ] I have written necessary rustdoc comments
- [ ] I have added necessary unit tests and integration tests
- [ ] I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features #7934).
- [ ] My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).

  • All checks passed in ./risedev check (or alias, ./risedev c)
    - [ ] My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)

- [ ] My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

- [ ] My PR contains user-facing changes.

Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #11054 (6006b22) into main (c76d2fb) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #11054      +/-   ##
==========================================
- Coverage   70.32%   70.32%   -0.01%     
==========================================
  Files        1366     1366              
  Lines      227745   227745              
==========================================
- Hits       160158   160154       -4     
- Misses      67587    67591       +4     
Flag Coverage Δ
rust 70.32% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wcy-fdu wcy-fdu requested a review from hzxa21 July 21, 2023 05:35
@wenym1 wenym1 requested review from Li0k and wenym1 July 25, 2023 08:29
grafana/risingwave-dev-dashboard.dashboard.py Outdated Show resolved Hide resolved
grafana/risingwave-dev-dashboard.dashboard.py Outdated Show resolved Hide resolved
grafana/risingwave-user-dashboard.dashboard.py Outdated Show resolved Hide resolved
src/stream/src/executor/mview/materialize.rs Outdated Show resolved Hide resolved
@wcy-fdu wcy-fdu requested a review from hzxa21 August 10, 2023 05:36
@wcy-fdu
Copy link
Contributor Author

wcy-fdu commented Aug 14, 2023

@hzxa21 PTAL❤️

@wcy-fdu wcy-fdu enabled auto-merge August 14, 2023 07:46
@wcy-fdu wcy-fdu disabled auto-merge August 14, 2023 12:10
@wcy-fdu wcy-fdu enabled auto-merge August 14, 2023 12:11
@wcy-fdu wcy-fdu added this pull request to the merge queue Aug 14, 2023
Merged via the queue into main with commit 989c607 Aug 14, 2023
38 checks passed
@wcy-fdu wcy-fdu deleted the wcy/remote_io branch August 14, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants