feat(stream): Dynamic filter watermark cache #11221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
commented
Jul 26, 2023
Comment on lines
+65
to
+77
| /// On receiving new RHS watermark: | ||
| /// 1. If empty, unused clean hint -> None. | ||
| /// 1. If watermark < lowest value | ||
| /// We don't need to issue delete range, | ||
| /// because are no values lower than lowest value. | ||
| /// Therefore, no values before watermark, and no values to clean. | ||
| /// We can set `unused_clean_hint` to None. | ||
| /// 2. Else watermark => lowest value | ||
| /// Need to issue delete range. | ||
| /// We can just issue delete range for (`lowest_value`, watermark]. | ||
| /// Set `unused_clean_hint` to `watermark`. | ||
| /// TODO(kwannoel): Optimization: If we move this to state table, we can set the delete range | ||
| /// lower bound. |
There was a problem hiding this comment.
Need to update this section. Does not seem really accurate. It should be last cleaned watermark, rather than new watermark.
New watermark is not cleaned yet.
kwannoel
commented
Jul 26, 2023
This was referenced Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note